Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-06 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 12/05/2013 03:13 AM, Markus Armbruster wrote: For error_propagate, if the destination error is error_abort, then the abort happens at propagation time. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- changed since v1: Delayed

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-06 Thread Peter Crosthwaite
On Fri, Dec 6, 2013 at 9:59 PM, Markus Armbruster arm...@redhat.com wrote: Eric Blake ebl...@redhat.com writes: On 12/05/2013 03:13 AM, Markus Armbruster wrote: For error_propagate, if the destination error is error_abort, then the abort happens at propagation time. Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-06 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Fri, Dec 6, 2013 at 9:59 PM, Markus Armbruster arm...@redhat.com wrote: Eric Blake ebl...@redhat.com writes: On 12/05/2013 03:13 AM, Markus Armbruster wrote: For error_propagate, if the destination error is error_abort, then the

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-05 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Add a special Error * that can be passed to error handling APIs to signal that any errors are fatal and should abort QEMU. There are two advantages to this: - allows for brevity when wishing to assert success of Error ** accepting

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-05 Thread Eric Blake
On 12/05/2013 03:13 AM, Markus Armbruster wrote: For error_propagate, if the destination error is error_abort, then the abort happens at propagation time. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- changed since v1: Delayed assertions that *errp == NULL. Care to

[Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-04 Thread Peter Crosthwaite
Add a special Error * that can be passed to error handling APIs to signal that any errors are fatal and should abort QEMU. There are two advantages to this: - allows for brevity when wishing to assert success of Error ** accepting APIs. No need for this pattern: Error * local_err =