Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-10 Thread Igor Mammedov
On Thu, 9 Jun 2016 14:29:00 -0300 Eduardo Habkost wrote: > On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote: > [...] > > + > > +if (local_err) { > > +error_propagate(errp, local_err); > > } > > error_propagate() already ignores

Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-10 Thread Igor Mammedov
On Thu, 9 Jun 2016 13:39:34 -0600 Eric Blake wrote: > On 06/09/2016 11:29 AM, Eduardo Habkost wrote: > > On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote: > > [...] > >> + > >> +if (local_err) { > >> +error_propagate(errp, local_err); > >> } >

Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 01:39:34PM -0600, Eric Blake wrote: > On 06/09/2016 11:29 AM, Eduardo Habkost wrote: > > On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote: > > [...] > >> + > >> +if (local_err) { > >> +error_propagate(errp, local_err); > >> } > > > >

Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-09 Thread Eric Blake
On 06/09/2016 11:29 AM, Eduardo Habkost wrote: > On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote: > [...] >> + >> +if (local_err) { >> +error_propagate(errp, local_err); >> } > > error_propagate() already ignores local_err==NULL so you don't > need to check it

[Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-09 Thread Igor Mammedov
From: Eduardo Habkost Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v1: - fix error handling in of +-feat, Igor

Re: [Qemu-devel] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote: [...] > + > +if (local_err) { > +error_propagate(errp, local_err); > } error_propagate() already ignores local_err==NULL so you don't need to check it first. I can change this while applying the patch, if you're OK.