Re: [Qemu-devel] [PATCH v2 1/7] s390x/pci: factor out endianess conversion

2017-11-21 Thread Pierre Morel
On 21/11/2017 11:35, Cornelia Huck wrote: On Thu, 16 Nov 2017 18:51:49 +0100 Pierre Morel wrote: There are two places where the same endianness conversion is done. Let's factor this out into a static function. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao Signed-off-by: Pierre Morel

Re: [Qemu-devel] [PATCH v2 1/7] s390x/pci: factor out endianess conversion

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:49 +0100 Pierre Morel wrote: > There are two places where the same endianness conversion > is done. > Let's factor this out into a static function. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao > Signed-off-by: Pierre Morel Your two s-o-bs look a bit od

[Qemu-devel] [PATCH v2 1/7] s390x/pci: factor out endianess conversion

2017-11-16 Thread Pierre Morel
There are two places where the same endianness conversion is done. Let's factor this out into a static function. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-inst.c | 59 +++- 1 file changed,