Re: [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit

2017-06-07 Thread Marc-André Lureau
Hi On Wed, Jun 7, 2017 at 8:57 PM Anthony PERARD wrote: > On Mon, May 29, 2017 at 12:45:43PM +0400, Marc-André Lureau wrote: > > Move all the fronted struct and methods to a seperate unit. This avoids > > accidentally mixing backend and frontend calls, and helps with

Re: [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit

2017-06-07 Thread Anthony PERARD
On Mon, May 29, 2017 at 12:45:43PM +0400, Marc-André Lureau wrote: > Move all the fronted struct and methods to a seperate unit. This avoids > accidentally mixing backend and frontend calls, and helps with readibilty. > > Make qemu_chr_replay() a macro shared by both char and char-fe. > > Export

Re: [Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit

2017-05-29 Thread Philippe Mathieu-Daudé
Hi Marc-André, Reviewed-by: Philippe Mathieu-Daudé On 05/29/2017 05:45 AM, Marc-André Lureau wrote: Move all the fronted struct and methods to a seperate unit. This avoids "frontend, separate" accidentally mixing backend and frontend calls, and helps with readibilty.

[Qemu-devel] [PATCH v2 11/14] char: move CharBackend handling in char-fe unit

2017-05-29 Thread Marc-André Lureau
Move all the fronted struct and methods to a seperate unit. This avoids accidentally mixing backend and frontend calls, and helps with readibilty. Make qemu_chr_replay() a macro shared by both char and char-fe. Export qemu_chr_write(), and use a macro for qemu_chr_write_all() (nb: yes,