Re: [Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-20 Thread Kevin Wolf
Am 19.09.2018 um 01:48 hat Max Reitz geschrieben: > On 18.09.18 17:04, Kevin Wolf wrote: > > Am 18.09.2018 um 16:11 hat Max Reitz geschrieben: > >> The user cannot do any graph manipulation then because the monitor is > >> blocked by starting the job. So the only issue would be other > >>

Re: [Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-18 Thread Max Reitz
On 18.09.18 17:04, Kevin Wolf wrote: > Am 18.09.2018 um 16:11 hat Max Reitz geschrieben: >> On 17.09.18 13:37, Kevin Wolf wrote: >>> Am 17.09.2018 um 00:05 hat Max Reitz geschrieben: On 14.09.18 18:25, Kevin Wolf wrote: > Am 13.09.2018 um 22:55 hat Max Reitz geschrieben: >> On

Re: [Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-18 Thread Kevin Wolf
Am 18.09.2018 um 16:11 hat Max Reitz geschrieben: > On 17.09.18 13:37, Kevin Wolf wrote: > > Am 17.09.2018 um 00:05 hat Max Reitz geschrieben: > >> On 14.09.18 18:25, Kevin Wolf wrote: > >>> Am 13.09.2018 um 22:55 hat Max Reitz geschrieben: > On 13.09.18 14:52, Kevin Wolf wrote: > > When

Re: [Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-18 Thread Max Reitz
On 17.09.18 13:37, Kevin Wolf wrote: > Am 17.09.2018 um 00:05 hat Max Reitz geschrieben: >> On 14.09.18 18:25, Kevin Wolf wrote: >>> Am 13.09.2018 um 22:55 hat Max Reitz geschrieben: On 13.09.18 14:52, Kevin Wolf wrote: > When starting an active commit job, other callbacks can run before

Re: [Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-17 Thread Kevin Wolf
Am 17.09.2018 um 00:05 hat Max Reitz geschrieben: > On 14.09.18 18:25, Kevin Wolf wrote: > > Am 13.09.2018 um 22:55 hat Max Reitz geschrieben: > >> On 13.09.18 14:52, Kevin Wolf wrote: > >>> When starting an active commit job, other callbacks can run before > >>> mirror_start_job() calls

Re: [Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-16 Thread Max Reitz
On 14.09.18 18:25, Kevin Wolf wrote: > Am 13.09.2018 um 22:55 hat Max Reitz geschrieben: >> On 13.09.18 14:52, Kevin Wolf wrote: >>> When starting an active commit job, other callbacks can run before >>> mirror_start_job() calls bdrv_ref() where needed and cause the nodes to >>> go away. Add

Re: [Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-14 Thread Kevin Wolf
Am 13.09.2018 um 22:55 hat Max Reitz geschrieben: > On 13.09.18 14:52, Kevin Wolf wrote: > > When starting an active commit job, other callbacks can run before > > mirror_start_job() calls bdrv_ref() where needed and cause the nodes to > > go away. Add another pair of bdrv_ref/unref() around it to

Re: [Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-13 Thread Max Reitz
On 13.09.18 22:55, Max Reitz wrote: > On 13.09.18 14:52, Kevin Wolf wrote: >> When starting an active commit job, other callbacks can run before >> mirror_start_job() calls bdrv_ref() where needed and cause the nodes to >> go away. Add another pair of bdrv_ref/unref() around it to protect >>

Re: [Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-13 Thread Max Reitz
On 13.09.18 14:52, Kevin Wolf wrote: > When starting an active commit job, other callbacks can run before > mirror_start_job() calls bdrv_ref() where needed and cause the nodes to > go away. Add another pair of bdrv_ref/unref() around it to protect > against this case. > > Signed-off-by: Kevin

[Qemu-devel] [PATCH v2 12/17] mirror: Fix potential use-after-free in active commit

2018-09-13 Thread Kevin Wolf
When starting an active commit job, other callbacks can run before mirror_start_job() calls bdrv_ref() where needed and cause the nodes to go away. Add another pair of bdrv_ref/unref() around it to protect against this case. Signed-off-by: Kevin Wolf --- block/mirror.c | 11 +++ 1 file