Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-12 Thread John Snow
On 03/11/2015 12:18 PM, Stefan Hajnoczi wrote: On Mon, Mar 02, 2015 at 06:20:00PM -0500, John Snow wrote: +static void dirty_bitmap_truncate(BdrvDirtyBitmap *bitmap, uint64_t size) +{ +/* Should only be frozen during a block backup job, which should have + * blocked any resize actions.

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-11 Thread Stefan Hajnoczi
On Mon, Mar 02, 2015 at 06:20:00PM -0500, John Snow wrote: > +static void dirty_bitmap_truncate(BdrvDirtyBitmap *bitmap, uint64_t size) > +{ > +/* Should only be frozen during a block backup job, which should have > + * blocked any resize actions. */ > +assert(!bdrv_dirty_bitmap_frozen(

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-04 Thread Max Reitz
On 2015-03-03 at 17:48, John Snow wrote: On 03/03/2015 04:27 PM, Max Reitz wrote: On 2015-03-03 at 16:24, John Snow wrote: On 03/03/2015 11:02 AM, Max Reitz wrote: On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 i

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-03 Thread John Snow
On 03/03/2015 04:27 PM, Max Reitz wrote: On 2015-03-03 at 16:24, John Snow wrote: On 03/03/2015 11:02 AM, Max Reitz wrote: On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 include/block/block.h | 1 + include/qem

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-03 Thread Max Reitz
On 2015-03-03 at 16:24, John Snow wrote: On 03/03/2015 11:02 AM, Max Reitz wrote: On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 include/block/block.h | 1 + include/qemu/hbitmap.h | 10 + util/hbitmap.c

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-03 Thread John Snow
On 03/03/2015 11:02 AM, Max Reitz wrote: On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 include/block/block.h | 1 + include/qemu/hbitmap.h | 10 + util/hbitmap.c | 55 +

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-03 Thread Max Reitz
On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 include/block/block.h | 1 + include/qemu/hbitmap.h | 10 + util/hbitmap.c | 55 ++ 4 files changed, 88

Re: [Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-03 Thread Max Reitz
On 2015-03-02 at 18:20, John Snow wrote: Signed-off-by: John Snow --- block.c| 22 include/block/block.h | 1 + include/qemu/hbitmap.h | 10 + util/hbitmap.c | 55 ++ 4 files changed, 88

[Qemu-devel] [PATCH v2 14/17] block: Resize bitmaps on bdrv_truncate

2015-03-02 Thread John Snow
Signed-off-by: John Snow --- block.c| 22 include/block/block.h | 1 + include/qemu/hbitmap.h | 10 + util/hbitmap.c | 55 ++ 4 files changed, 88 insertions(+) diff --git a/block.c b/block.c in