Re: [Qemu-devel] [PATCH v2 15/17] block: Switch discard length bounds to byte-based

2016-06-21 Thread Eric Blake
On 06/21/2016 08:05 AM, Kevin Wolf wrote: > Am 14.06.2016 um 23:30 hat Eric Blake geschrieben: >> Sector-based limits are awkward to think about; in our on-going >> quest to move to byte-based interfaces, convert max_discard and >> discard_alignment. Rename them, using 'pdiscard' as an aid to >> t

Re: [Qemu-devel] [PATCH v2 15/17] block: Switch discard length bounds to byte-based

2016-06-21 Thread Kevin Wolf
Am 14.06.2016 um 23:30 hat Eric Blake geschrieben: > Sector-based limits are awkward to think about; in our on-going > quest to move to byte-based interfaces, convert max_discard and > discard_alignment. Rename them, using 'pdiscard' as an aid to > track which remaining discard interfaces need con

Re: [Qemu-devel] [PATCH v2 15/17] block: Switch discard length bounds to byte-based

2016-06-16 Thread Fam Zheng
On Thu, 06/16 08:21, Eric Blake wrote: > On 06/15/2016 11:46 PM, Fam Zheng wrote: > > On Tue, 06/14 15:30, Eric Blake wrote: > >> Sector-based limits are awkward to think about; in our on-going > >> quest to move to byte-based interfaces, convert max_discard and > >> discard_alignment. Rename them

Re: [Qemu-devel] [PATCH v2 15/17] block: Switch discard length bounds to byte-based

2016-06-16 Thread Eric Blake
On 06/15/2016 11:46 PM, Fam Zheng wrote: > On Tue, 06/14 15:30, Eric Blake wrote: >> Sector-based limits are awkward to think about; in our on-going >> quest to move to byte-based interfaces, convert max_discard and >> discard_alignment. Rename them, using 'pdiscard' as an aid to >> track which re

Re: [Qemu-devel] [PATCH v2 15/17] block: Switch discard length bounds to byte-based

2016-06-15 Thread Fam Zheng
On Tue, 06/14 15:30, Eric Blake wrote: > Sector-based limits are awkward to think about; in our on-going > quest to move to byte-based interfaces, convert max_discard and > discard_alignment. Rename them, using 'pdiscard' as an aid to > track which remaining discard interfaces need conversion, and

[Qemu-devel] [PATCH v2 15/17] block: Switch discard length bounds to byte-based

2016-06-14 Thread Eric Blake
Sector-based limits are awkward to think about; in our on-going quest to move to byte-based interfaces, convert max_discard and discard_alignment. Rename them, using 'pdiscard' as an aid to track which remaining discard interfaces need conversion, and so that the compiler will help us catch the ch