Re: [Qemu-devel] [PATCH v2 2/2] migration: drop unused VMStateField.start

2017-02-01 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 01/31/2017 09:00 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 10/20/2016 03:25 PM, Halil Pasic wrote: > >>> diff --git a/migration/vmstate.c b/migration/vmstate.c > >>> index fc29ac

Re: [Qemu-devel] [PATCH v2 2/2] migration: drop unused VMStateField.start

2017-02-01 Thread Halil Pasic
On 01/31/2017 09:00 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 10/20/2016 03:25 PM, Halil Pasic wrote: >>> diff --git a/migration/vmstate.c b/migration/vmstate.c >>> index fc29acf..8767e40 100644 >>> --- a/migration/vmstate.c >>> +++ b/migratio

Re: [Qemu-devel] [PATCH v2 2/2] migration: drop unused VMStateField.start

2017-01-31 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 10/20/2016 03:25 PM, Halil Pasic wrote: > > diff --git a/migration/vmstate.c b/migration/vmstate.c > > index fc29acf..8767e40 100644 > > --- a/migration/vmstate.c > > +++ b/migration/vmstate.c > > @@ -66,10 +66,10 @@ static void *vmstate_ba

Re: [Qemu-devel] [PATCH v2 2/2] migration: drop unused VMStateField.start

2017-01-30 Thread Halil Pasic
On 10/20/2016 03:25 PM, Halil Pasic wrote: > diff --git a/migration/vmstate.c b/migration/vmstate.c > index fc29acf..8767e40 100644 > --- a/migration/vmstate.c > +++ b/migration/vmstate.c > @@ -66,10 +66,10 @@ static void *vmstate_base_addr(void *opaque, VMStateField > *field, bool alloc) >

[Qemu-devel] [PATCH v2 2/2] migration: drop unused VMStateField.start

2016-10-20 Thread Halil Pasic
The member VMStateField.start was solely used to implement the partial data migration for VBUFFER data (basically provide migration for a sub-buffer). However the implementation of this feature seems broken to me, but this goes unnoticed since the feature is not used at all. Instead of fixing it le