Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-06-05 Thread Amos Kong
On Wed, May 29, 2013 at 01:31:12PM +0800, Jason Wang wrote: On 05/16/2013 07:07 PM, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt. The previous patch adds QMP event to notify management of mac-table change. This patch adds a monitor command to query rx

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-28 Thread Jason Wang
On 05/16/2013 07:07 PM, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt. The previous patch adds QMP event to notify management of mac-table change. This patch adds a monitor command to query rx mode information of mac-tables. (qemu) info mac-table vnet0

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-22 Thread Amos Kong
On Thu, May 16, 2013 at 09:38:01AM -0600, Eric Blake wrote: On 05/16/2013 05:07 AM, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt. The previous patch adds QMP event to notify management of mac-table change. This patch adds a monitor command to query rx

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-21 Thread Stefan Hajnoczi
On Tue, May 21, 2013 at 12:46:09PM +0800, Amos Kong wrote: On Fri, May 17, 2013 at 09:39:31AM +0200, Stefan Hajnoczi wrote: On Thu, May 16, 2013 at 07:07:25PM +0800, Amos Kong wrote: Hi Stefan, @@ -961,6 +961,44 @@ void print_net_client(Monitor *mon, NetClientState *nc)

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-20 Thread Amos Kong
On Thu, May 16, 2013 at 03:19:54PM +0300, Michael S. Tsirkin wrote: On Thu, May 16, 2013 at 07:07:25PM +0800, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt. The previous patch adds QMP event to notify management of mac-table change. This patch adds a

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-20 Thread Amos Kong
On Fri, May 17, 2013 at 09:39:31AM +0200, Stefan Hajnoczi wrote: On Thu, May 16, 2013 at 07:07:25PM +0800, Amos Kong wrote: Hi Stefan, @@ -961,6 +961,44 @@ void print_net_client(Monitor *mon, NetClientState *nc) nc-info_str); } +MacTableInfoList

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-17 Thread Stefan Hajnoczi
On Thu, May 16, 2013 at 07:07:25PM +0800, Amos Kong wrote: @@ -961,6 +961,44 @@ void print_net_client(Monitor *mon, NetClientState *nc) nc-info_str); } +MacTableInfoList *qmp_query_mac_table(bool has_name, const char *name, + Error

[Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-16 Thread Amos Kong
We want to implement mac programming over macvtap through Libvirt. The previous patch adds QMP event to notify management of mac-table change. This patch adds a monitor command to query rx mode information of mac-tables. (qemu) info mac-table vnet0 vnet0: \ promisc: on \ allmulti: off \

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 07:07:25PM +0800, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt. The previous patch adds QMP event to notify management of mac-table change. This patch adds a monitor command to query rx mode information of mac-tables. (qemu) info

Re: [Qemu-devel] [PATCH v2 2/2] net: introduce command to query mac-table information

2013-05-16 Thread Eric Blake
On 05/16/2013 05:07 AM, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt. The previous patch adds QMP event to notify management of mac-table change. This patch adds a monitor command to query rx mode information of mac-tables. Focusing my review on just