Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-05 Thread Michael S. Tsirkin
On Thu, Jan 31, 2019 at 06:37:13PM +0100, Stefano Garzarella wrote: > On Thu, Jan 31, 2019 at 11:43:07AM -0500, Michael S. Tsirkin wrote: > > On Thu, Jan 31, 2019 at 04:50:46PM +0100, Stefano Garzarella wrote: > > > On Thu, Jan 31, 2019 at 03:40:38PM +, Dr. David Alan Gilbert wrote: > > > > *

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-04 Thread Stefano Garzarella
On Mon, Feb 04, 2019 at 08:37:28AM -0500, Michael S. Tsirkin wrote: > On Mon, Feb 04, 2019 at 11:16:14AM +0100, Stefano Garzarella wrote: > > On Mon, Feb 04, 2019 at 11:33:07AM +0800, Stefan Hajnoczi wrote: > > > On Fri, Feb 01, 2019 at 06:18:52PM +0100, Stefano Garzarella wrote: > > > > On Fri,

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-04 Thread Michael S. Tsirkin
On Mon, Feb 04, 2019 at 11:16:14AM +0100, Stefano Garzarella wrote: > On Mon, Feb 04, 2019 at 11:33:07AM +0800, Stefan Hajnoczi wrote: > > On Fri, Feb 01, 2019 at 06:18:52PM +0100, Stefano Garzarella wrote: > > > On Fri, Feb 1, 2019 at 4:17 PM Michael S. Tsirkin wrote: > > > > On Thu, Jan 31,

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-04 Thread Stefano Garzarella
On Mon, Feb 04, 2019 at 11:33:07AM +0800, Stefan Hajnoczi wrote: > On Fri, Feb 01, 2019 at 06:18:52PM +0100, Stefano Garzarella wrote: > > On Fri, Feb 1, 2019 at 4:17 PM Michael S. Tsirkin wrote: > > > On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > > > > In order to avoid

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-03 Thread Stefan Hajnoczi
On Fri, Feb 01, 2019 at 06:18:52PM +0100, Stefano Garzarella wrote: > On Fri, Feb 1, 2019 at 4:17 PM Michael S. Tsirkin wrote: > > On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > > > In order to avoid migration issues, we enable DISCARD and > > > WRITE ZEROES features only

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-01 Thread Stefano Garzarella
On Fri, Feb 1, 2019 at 4:17 PM Michael S. Tsirkin wrote: > > On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > > In order to avoid migration issues, we enable DISCARD and > > WRITE ZEROES features only for machine type >= 4.0 > > > > Suggested-by: Dr. David Alan Gilbert > >

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-01 Thread Michael S. Tsirkin
On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > In order to avoid migration issues, we enable DISCARD and > WRITE ZEROES features only for machine type >= 4.0 > > Suggested-by: Dr. David Alan Gilbert > Signed-off-by: Stefano Garzarella > --- > hw/block/virtio-blk.c

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-01 Thread Stefan Hajnoczi
On Fri, Feb 01, 2019 at 10:09:08AM +0100, Stefano Garzarella wrote: > On Fri, Feb 01, 2019 at 12:29:28PM +0800, Stefan Hajnoczi wrote: > > On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > > > In order to avoid migration issues, we enable DISCARD and > > > WRITE ZEROES features

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-01 Thread Stefano Garzarella
On Fri, Feb 01, 2019 at 12:29:28PM +0800, Stefan Hajnoczi wrote: > On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > > In order to avoid migration issues, we enable DISCARD and > > WRITE ZEROES features only for machine type >= 4.0 > > Please use two separate properties that

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-01-31 Thread Stefan Hajnoczi
On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > In order to avoid migration issues, we enable DISCARD and > WRITE ZEROES features only for machine type >= 4.0 Please use two separate properties that correspond to the VIRTIO_BLK_F_DISCARD and VIRTIO_BLK_F_WRITE_ZEROES

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-01-31 Thread Stefano Garzarella
On Thu, Jan 31, 2019 at 11:43:07AM -0500, Michael S. Tsirkin wrote: > On Thu, Jan 31, 2019 at 04:50:46PM +0100, Stefano Garzarella wrote: > > On Thu, Jan 31, 2019 at 03:40:38PM +, Dr. David Alan Gilbert wrote: > > > * Stefano Garzarella (sgarz...@redhat.com) wrote: > > > > In order to avoid

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-01-31 Thread Michael S. Tsirkin
On Thu, Jan 31, 2019 at 04:50:46PM +0100, Stefano Garzarella wrote: > On Thu, Jan 31, 2019 at 03:40:38PM +, Dr. David Alan Gilbert wrote: > > * Stefano Garzarella (sgarz...@redhat.com) wrote: > > > In order to avoid migration issues, we enable DISCARD and > > > WRITE ZEROES features only for

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-01-31 Thread Dr. David Alan Gilbert
* Stefano Garzarella (sgarz...@redhat.com) wrote: > On Thu, Jan 31, 2019 at 03:40:38PM +, Dr. David Alan Gilbert wrote: > > * Stefano Garzarella (sgarz...@redhat.com) wrote: > > > In order to avoid migration issues, we enable DISCARD and > > > WRITE ZEROES features only for machine type >= 4.0

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-01-31 Thread Dr. David Alan Gilbert
* Stefano Garzarella (sgarz...@redhat.com) wrote: > In order to avoid migration issues, we enable DISCARD and > WRITE ZEROES features only for machine type >= 4.0 > > Suggested-by: Dr. David Alan Gilbert > Signed-off-by: Stefano Garzarella > --- > hw/block/virtio-blk.c | 2 ++ >

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-01-31 Thread Stefano Garzarella
On Thu, Jan 31, 2019 at 03:40:38PM +, Dr. David Alan Gilbert wrote: > * Stefano Garzarella (sgarz...@redhat.com) wrote: > > In order to avoid migration issues, we enable DISCARD and > > WRITE ZEROES features only for machine type >= 4.0 > > > > Suggested-by: Dr. David Alan Gilbert > >

[Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-01-31 Thread Stefano Garzarella
In order to avoid migration issues, we enable DISCARD and WRITE ZEROES features only for machine type >= 4.0 Suggested-by: Dr. David Alan Gilbert Signed-off-by: Stefano Garzarella --- hw/block/virtio-blk.c | 2 ++ hw/core/machine.c | 1 + include/hw/virtio/virtio-blk.h |