Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Eric Blake
On 04/05/2017 06:54 AM, Paolo Bonzini wrote: > > > On 05/04/2017 11:01, Richard W.M. Jones wrote: >> On Wed, Apr 05, 2017 at 10:38:37AM +0200, Julia Lawall wrote: >>> OK, there is nothing special about g_assert_cmpint, but Coccinelle expects >>> expressions or types in function argument lists,

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Julia Lawall
On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > On Wed, Apr 05, 2017 at 10:21:13AM +0200, Julia Lawall wrote: > > > > > > On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > > > > > On Tue, Apr 04, 2017 at 05:41:08PM -0500, Eric Blake wrote: > > > > On 01/19/2017 08:38 AM, Eric Blake wrote: > > > >

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Julia Lawall
On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > On Tue, Apr 04, 2017 at 05:41:08PM -0500, Eric Blake wrote: > > On 01/19/2017 08:38 AM, Eric Blake wrote: > > > On 01/19/2017 03:25 AM, Markus Armbruster wrote: > > >> Eric Blake writes: > > >> > > >>> Quite a few users of

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Paolo Bonzini
On 05/04/2017 11:01, Richard W.M. Jones wrote: > On Wed, Apr 05, 2017 at 10:38:37AM +0200, Julia Lawall wrote: >> OK, there is nothing special about g_assert_cmpint, but Coccinelle expects >> expressions or types in function argument lists, so it gives a parse error >> on finding an ==. > > I

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Richard W.M. Jones
On Wed, Apr 05, 2017 at 10:38:37AM +0200, Julia Lawall wrote: > OK, there is nothing special about g_assert_cmpint, but Coccinelle expects > expressions or types in function argument lists, so it gives a parse error > on finding an ==. I should have checked the coccinelle mailing list before

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Richard W.M. Jones
On Wed, Apr 05, 2017 at 10:21:13AM +0200, Julia Lawall wrote: > > > On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > > > On Tue, Apr 04, 2017 at 05:41:08PM -0500, Eric Blake wrote: > > > On 01/19/2017 08:38 AM, Eric Blake wrote: > > > > On 01/19/2017 03:25 AM, Markus Armbruster wrote: > > > >>

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Richard W.M. Jones
On Tue, Apr 04, 2017 at 05:41:08PM -0500, Eric Blake wrote: > On 01/19/2017 08:38 AM, Eric Blake wrote: > > On 01/19/2017 03:25 AM, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >>> Quite a few users of qdict_put() were manually wrapping a > >>> non-QObject. We can

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-04 Thread Eric Blake
On 01/19/2017 08:38 AM, Eric Blake wrote: > On 01/19/2017 03:25 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Quite a few users of qdict_put() were manually wrapping a >>> non-QObject. We can make such call-sites shorter, by providing >>> common macros to do the

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-01-19 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 10:16:49AM -0600, Eric Blake wrote: > Quite a few users of qdict_put() were manually wrapping a > non-QObject. We can make such call-sites shorter, by providing > common macros to do the tedious work. Also shorten nearby > qdict_put_obj(,,QOBJECT()) sequences. > >

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-01-19 Thread Eric Blake
On 01/19/2017 03:25 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Quite a few users of qdict_put() were manually wrapping a >> non-QObject. We can make such call-sites shorter, by providing >> common macros to do the tedious work. Also shorten nearby >>

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-01-19 Thread Markus Armbruster
Eric Blake writes: > Quite a few users of qdict_put() were manually wrapping a > non-QObject. We can make such call-sites shorter, by providing > common macros to do the tedious work. Also shorten nearby > qdict_put_obj(,,QOBJECT()) sequences. > > Signed-off-by: Eric Blake

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-01-19 Thread Marc-André Lureau
Hi On Wed, Jan 18, 2017 at 8:44 PM Eric Blake wrote: > Quite a few users of qdict_put() were manually wrapping a > non-QObject. We can make such call-sites shorter, by providing > common macros to do the tedious work. Also shorten nearby > qdict_put_obj(,,QOBJECT())

[Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-01-18 Thread Eric Blake
Quite a few users of qdict_put() were manually wrapping a non-QObject. We can make such call-sites shorter, by providing common macros to do the tedious work. Also shorten nearby qdict_put_obj(,,QOBJECT()) sequences. Signed-off-by: Eric Blake Reviewed-by: Alberto Garcia