Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-20 Thread Max Reitz
On 2014-11-18 at 21:26, Eric Blake wrote: On 11/17/2014 05:06 AM, Max Reitz wrote: Umm, that sounds backwards from what you document. It's a good test of the _new_ reftable needing a second round of allocations. So keep it with corrected comments. But I think you _intended_ to write a test

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-20 Thread Max Reitz
On 2014-11-19 at 06:52, Eric Blake wrote: On 11/18/2014 01:26 PM, Eric Blake wrote: Now, in response to your question about some other 3-pass inducing pattern, let's think back to v1, where you questioned what would happen if a hole in the reftable gets turned into data due to a later

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-20 Thread Eric Blake
On 11/20/2014 07:03 AM, Max Reitz wrote: Some people may ask why the walks are performed in a loop without a fixed limit (because they can't find cases where allocations haven't settled at the third pass). But I doubt that'll be a serious problem. It's much easier to have such a basically

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-20 Thread Eric Blake
On 11/20/2014 06:48 AM, Max Reitz wrote: Sounds good, the only problem is that I'd have to hand-craft the image myself, because qemu generally uses self-references for refblocks (when allocating new refblocks, they will contain their own refcount). I think this already would be too much

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-18 Thread Eric Blake
On 11/17/2014 05:06 AM, Max Reitz wrote: Umm, that sounds backwards from what you document. It's a good test of the _new_ reftable needing a second round of allocations. So keep it with corrected comments. But I think you _intended_ to write a test that starts with a refcount_width=64

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-18 Thread Eric Blake
On 11/18/2014 01:26 PM, Eric Blake wrote: Now, in response to your question about some other 3-pass inducing pattern, let's think back to v1, where you questioned what would happen if a hole in the reftable gets turned into data due to a later allocation. Let's see if I can come up with a

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-17 Thread Max Reitz
On 2014-11-15 at 15:50, Eric Blake wrote: On 11/14/2014 06:06 AM, Max Reitz wrote: Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with refcount_width=1). Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/112

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-17 Thread Max Reitz
On 2014-11-17 at 09:34, Max Reitz wrote: On 2014-11-15 at 15:50, Eric Blake wrote: On 11/14/2014 06:06 AM, Max Reitz wrote: Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with refcount_width=1). Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-17 Thread Max Reitz
On 2014-11-17 at 11:38, Max Reitz wrote: On 2014-11-17 at 09:34, Max Reitz wrote: On 2014-11-15 at 15:50, Eric Blake wrote: On 11/14/2014 06:06 AM, Max Reitz wrote: Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-17 Thread Max Reitz
On 2014-11-15 at 15:50, Eric Blake wrote: On 11/14/2014 06:06 AM, Max Reitz wrote: Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with refcount_width=1). Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/112

Re: [Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-15 Thread Eric Blake
On 11/14/2014 06:06 AM, Max Reitz wrote: Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with refcount_width=1). Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/112 | 252

[Qemu-devel] [PATCH v2 21/21] iotests: Add test for different refcount widths

2014-11-14 Thread Max Reitz
Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with refcount_width=1). Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/112 | 252 + tests/qemu-iotests/112.out |