Re: [Qemu-devel] [PATCH v2 22/27] qdev: access properties via QOM

2012-02-12 Thread Paolo Bonzini
On 02/11/2012 04:46 PM, Blue Swirl wrote: Program received signal SIGSEGV, Segmentation fault. qdev_prop_set_chr (dev=0x1365580, name=0x6ed811 chrB, value=0x0) at /src/qemu/hw/qdev-properties.c:1142 1142assert(value-label); (gdb) bt #0 qdev_prop_set_chr (dev=0x1365580, name=0x6ed811

Re: [Qemu-devel] [PATCH v2 22/27] qdev: access properties via QOM

2012-02-11 Thread Blue Swirl
On Sat, Feb 4, 2012 at 08:02, Paolo Bonzini pbonz...@redhat.com wrote: Do not poke anymore in the struct when accessing qdev properties. Instead, ask the object to set the right value. Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---  hw/qdev-addr.c       |    5 ++-  

Re: [Qemu-devel] [PATCH v2 22/27] qdev: access properties via QOM

2012-02-06 Thread Anthony Liguori
On 02/04/2012 02:02 AM, Paolo Bonzini wrote: Do not poke anymore in the struct when accessing qdev properties. Instead, ask the object to set the right value. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Regards, Anthony Liguori ---

[Qemu-devel] [PATCH v2 22/27] qdev: access properties via QOM

2012-02-04 Thread Paolo Bonzini
Do not poke anymore in the struct when accessing qdev properties. Instead, ask the object to set the right value. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/qdev-addr.c |5 ++- hw/qdev-properties.c | 78 ++--- hw/qdev.h