Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-17 Thread Lluís
Stefan Hajnoczi writes: If you don't get around to it I'll do it sometime but I'm short on time right now. Wanted to let you know in case you're waiting for more discussion on this thread. Sure, don't worry. I do not have enough time right now either, so I'll tell you if I start to implement

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-16 Thread Stefan Hajnoczi
On Thu, Nov 11, 2010 at 9:31 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Nov 10, 2010 at 9:20 PM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Wed, Nov 10, 2010 at 7:57 PM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Wed, Nov 10, 2010 at 5:59 PM, Lluís xscr...@gmx.net

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-11 Thread Stefan Hajnoczi
On Wed, Nov 10, 2010 at 9:20 PM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Wed, Nov 10, 2010 at 7:57 PM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Wed, Nov 10, 2010 at 5:59 PM, Lluís xscr...@gmx.net wrote: So, my patch is just a matter of having all events available _only_

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Blue Swirl
On Tue, Nov 9, 2010 at 2:08 PM, Lluís xscr...@gmx.net wrote: Enable all trace events by default, assuming their frequency is relatively low, so there will be no measurable performace impact. Even if the impact for one tracepoint is low, if all tracepoints are enabled, eventually (considering

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Lluís
Blue Swirl writes: On Tue, Nov 9, 2010 at 2:08 PM, Lluís xscr...@gmx.net wrote: Enable all trace events by default, assuming their frequency is relatively low, so there will be no measurable performace impact. Even if the impact for one tracepoint is low, if all tracepoints are enabled,

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 5:59 PM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Tue, Nov 9, 2010 at 2:08 PM, Lluís xscr...@gmx.net wrote: Enable all trace events by default, assuming their frequency is relatively low, so there will be no measurable performace impact. Even if the

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Lluís
Blue Swirl writes: On Wed, Nov 10, 2010 at 5:59 PM, Lluís xscr...@gmx.net wrote: So, my patch is just a matter of having all events available _only_ when you use a backend other than nop. Then the default for simpletrace (and dtrace?) should also be disabled initial state. If you have 1000

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Blue Swirl
On Wed, Nov 10, 2010 at 7:57 PM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Wed, Nov 10, 2010 at 5:59 PM, Lluís xscr...@gmx.net wrote: So, my patch is just a matter of having all events available _only_ when you use a backend other than nop. Then the default for simpletrace (and

Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-10 Thread Lluís
Blue Swirl writes: On Wed, Nov 10, 2010 at 7:57 PM, Lluís xscr...@gmx.net wrote: Blue Swirl writes: On Wed, Nov 10, 2010 at 5:59 PM, Lluís xscr...@gmx.net wrote: So, my patch is just a matter of having all events available _only_ when you use a backend other than nop. Then the default

[Qemu-devel] [PATCH v2 3/3] trace: enable all events by default

2010-11-09 Thread Lluís
Enable all trace events by default, assuming their frequency is relatively low, so there will be no measurable performace impact. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- trace-events | 251 +- 1 files changed, 124