Re: [Qemu-devel] [PATCH v2 3/4] optionrom: add new PVH option rom

2019-01-16 Thread Stefano Garzarella
Hi Liam, On Wed, Jan 16, 2019 at 10:16:04AM +, Liam Merwick wrote: > Hi Stefano, > > Code LGTM, just a few minor comments below > > On 15/01/2019 10:00, Stefano Garzarella wrote: > > The new pvh.bin option rom can be used with SeaBIOS to boot > > uncompressed kernel using the x86/HVM direct

Re: [Qemu-devel] [PATCH v2 3/4] optionrom: add new PVH option rom

2019-01-16 Thread Liam Merwick
Hi Stefano, Code LGTM, just a few minor comments below On 15/01/2019 10:00, Stefano Garzarella wrote: The new pvh.bin option rom can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. pvh.S contains the entry point of the option rom. It runs in real mode,

[Qemu-devel] [PATCH v2 3/4] optionrom: add new PVH option rom

2019-01-15 Thread Stefano Garzarella
The new pvh.bin option rom can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. pvh.S contains the entry point of the option rom. It runs in real mode, loads the e820 table querying the BIOS, and then it switches to 32bit protect mode and jump to the