Re: [Qemu-devel] [PATCH v2 31/40] job: Add job_is_ready()

2018-05-25 Thread Kevin Wolf
Am 24.05.2018 um 19:25 hat John Snow geschrieben: > >>> diff --git a/job.c b/job.c > >>> index af31de4669..66ee26f2a0 100644 > >>> --- a/job.c > >>> +++ b/job.c > >>> @@ -199,6 +199,28 @@ bool job_is_cancelled(Job *job) > >>> return job->cancelled; > >>> } > >>> > >>> +bool

Re: [Qemu-devel] [PATCH v2 31/40] job: Add job_is_ready()

2018-05-24 Thread John Snow
On 05/24/2018 04:30 AM, Kevin Wolf wrote: > Am 24.05.2018 um 01:42 hat John Snow geschrieben: >> On 05/18/2018 09:21 AM, Kevin Wolf wrote: >>> Instead of having a 'bool ready' in BlockJob, add a function that >>> derives its value from the job status. >>> >>> At the same time, this fixes the

Re: [Qemu-devel] [PATCH v2 31/40] job: Add job_is_ready()

2018-05-24 Thread Kevin Wolf
Am 24.05.2018 um 01:42 hat John Snow geschrieben: > On 05/18/2018 09:21 AM, Kevin Wolf wrote: > > Instead of having a 'bool ready' in BlockJob, add a function that > > derives its value from the job status. > > > > At the same time, this fixes the behaviour to match what the QAPI > >

Re: [Qemu-devel] [PATCH v2 31/40] job: Add job_is_ready()

2018-05-23 Thread John Snow
On 05/18/2018 09:21 AM, Kevin Wolf wrote: > Instead of having a 'bool ready' in BlockJob, add a function that > derives its value from the job status. > > At the same time, this fixes the behaviour to match what the QAPI > documentation promises for query-block-job: 'true if the job may be >

[Qemu-devel] [PATCH v2 31/40] job: Add job_is_ready()

2018-05-18 Thread Kevin Wolf
Instead of having a 'bool ready' in BlockJob, add a function that derives its value from the job status. At the same time, this fixes the behaviour to match what the QAPI documentation promises for query-block-job: 'true if the job may be completed'. When the ready flag was introduced in commit