On Tue, 29 Jan 2019 at 08:21, Paolo Bonzini wrote:
>
> On 28/01/19 19:02, Peter Maydell wrote:
> >
> > I don't understand why the build/config-all-devices.mak versions of
> > the defines of CONFIG_FOO variables are so weird:
> >
> > CONFIG_ACPI:=$(findstring y,$(CONFIG_ACPI)y)
> >
> > ...are they
On 28/01/19 19:02, Peter Maydell wrote:
>
> I don't understand why the build/config-all-devices.mak versions of
> the defines of CONFIG_FOO variables are so weird:
>
> CONFIG_ACPI:=$(findstring y,$(CONFIG_ACPI)y)
>
> ...are they really intended to be self-referential like that?
Yes,
On 2019-01-28 18:47, Philippe Mathieu-Daudé wrote:
> Cc'ing Thomas/Paolo for Makefile rules...
>
> On 1/24/19 12:43 PM, Gerd Hoffmann wrote:
>> On Thu, Jan 24, 2019 at 02:15:54AM +0100, Philippe Mathieu-Daudé wrote:
>>> Move the complexity of milkymist_tmu2_create() into the
>>> source file.
On 1/28/19 7:02 PM, Peter Maydell wrote:
> On Mon, 28 Jan 2019 at 17:47, Philippe Mathieu-Daudé
> wrote:
>>
>> Cc'ing Thomas/Paolo for Makefile rules...
>>
>> On 1/24/19 12:43 PM, Gerd Hoffmann wrote:
>>> Oops, fails the build:
>>>
>>> LINKlm32-softmmu/qemu-system-lm32
>>>
Cc'ing Thomas/Paolo for Makefile rules...
On 1/24/19 12:43 PM, Gerd Hoffmann wrote:
> On Thu, Jan 24, 2019 at 02:15:54AM +0100, Philippe Mathieu-Daudé wrote:
>> Move the complexity of milkymist_tmu2_create() into the
>> source file. Doing so we avoid to include the X11/OpenGL
>> headers in all
On Mon, 28 Jan 2019 at 17:47, Philippe Mathieu-Daudé wrote:
>
> Cc'ing Thomas/Paolo for Makefile rules...
>
> On 1/24/19 12:43 PM, Gerd Hoffmann wrote:
> > Oops, fails the build:
> >
> > LINKlm32-softmmu/qemu-system-lm32
> > hw/lm32/milkymist.o: In function `milkymist_init':
> >
On 1/24/19 12:43 PM, Gerd Hoffmann wrote:
> On Thu, Jan 24, 2019 at 02:15:54AM +0100, Philippe Mathieu-Daudé wrote:
>> Move the complexity of milkymist_tmu2_create() into the
>> source file. Doing so we avoid to include the X11/OpenGL
>> headers in all LM32 devices, and we also avoid the duplicate
On Thu, Jan 24, 2019 at 02:15:54AM +0100, Philippe Mathieu-Daudé wrote:
> Move the complexity of milkymist_tmu2_create() into the
> source file. Doing so we avoid to include the X11/OpenGL
> headers in all LM32 devices, and we also avoid the duplicate
> declaration of glx_fbconfig_attr[] (it is
Move the complexity of milkymist_tmu2_create() into the
source file. Doing so we avoid to include the X11/OpenGL
headers in all LM32 devices, and we also avoid the duplicate
declaration of glx_fbconfig_attr[] (it is already declared
in hw/display/milkymist-tmu2.c).
Since TYPE_MILKYMIST_TMU2 is now
