Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 09:25:29AM +0100, Gerd Hoffmann wrote: Hi, ok, I'll take it. Note that I'm going to not send the qxl screendump behavior changing patch again, I think all alternatives to a real async screendump suck, including libvirt changes, and the current behavior of

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 09:14:46AM +0100, Gerd Hoffmann wrote: Hi, Some solutions that come to my mind: 1. Pool the screendump file creation from a timer. Cons: it may return before the file is fully written to disk We know what the file size should be, so we can poll

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 08:37:13 + Daniel P. Berrange berra...@redhat.com wrote: First, with this applied you will not know the size in advance. Also one of the approaches discussed is to allow passing in a file handle. That is a possible way to handle async screendumps too: just write to

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 09:32:58AM -0300, Luiz Capitulino wrote: On Wed, 14 Mar 2012 08:37:13 + Daniel P. Berrange berra...@redhat.com wrote: First, with this applied you will not know the size in advance. Also one of the approaches discussed is to allow passing in a file handle.

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Daniel P. Berrange
On Wed, Mar 14, 2012 at 03:14:10PM +0200, Alon Levy wrote: On Wed, Mar 14, 2012 at 09:32:58AM -0300, Luiz Capitulino wrote: On Wed, 14 Mar 2012 08:37:13 + Daniel P. Berrange berra...@redhat.com wrote: First, with this applied you will not know the size in advance. Also one of

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Luiz Capitulino
On Wed, 14 Mar 2012 15:14:10 +0200 Alon Levy al...@redhat.com wrote: On Wed, Mar 14, 2012 at 09:32:58AM -0300, Luiz Capitulino wrote: On Wed, 14 Mar 2012 08:37:13 + Daniel P. Berrange berra...@redhat.com wrote: First, with this applied you will not know the size in advance. Also

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-14 Thread Alon Levy
On Wed, Mar 14, 2012 at 10:18:12AM -0300, Luiz Capitulino wrote: On Wed, 14 Mar 2012 15:14:10 +0200 Alon Levy al...@redhat.com wrote: On Wed, Mar 14, 2012 at 09:32:58AM -0300, Luiz Capitulino wrote: On Wed, 14 Mar 2012 08:37:13 + Daniel P. Berrange berra...@redhat.com wrote:

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-13 Thread Luiz Capitulino
On Sun, 11 Mar 2012 21:26:43 +0200 Alon Levy al...@redhat.com wrote: Passes the Monitor ptr to the screendump implementation to all for monitor suspend and resume for qxl to fix screendump regression. graphics_console_init signature change required touching every implemented of screen_dump.

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-13 Thread Alon Levy
On Tue, Mar 13, 2012 at 10:35:55AM -0300, Luiz Capitulino wrote: On Sun, 11 Mar 2012 21:26:43 +0200 Alon Levy al...@redhat.com wrote: Passes the Monitor ptr to the screendump implementation to all for monitor suspend and resume for qxl to fix screendump regression.

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-13 Thread Luiz Capitulino
On Tue, 13 Mar 2012 16:46:12 +0200 Alon Levy al...@redhat.com wrote: On Tue, Mar 13, 2012 at 10:35:55AM -0300, Luiz Capitulino wrote: On Sun, 11 Mar 2012 21:26:43 +0200 Alon Levy al...@redhat.com wrote: Passes the Monitor ptr to the screendump implementation to all for monitor

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-13 Thread Alon Levy
On Tue, Mar 13, 2012 at 12:59:17PM -0300, Luiz Capitulino wrote: On Tue, 13 Mar 2012 16:46:12 +0200 Alon Levy al...@redhat.com wrote: On Tue, Mar 13, 2012 at 10:35:55AM -0300, Luiz Capitulino wrote: On Sun, 11 Mar 2012 21:26:43 +0200 Alon Levy al...@redhat.com wrote: Passes the

Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-13 Thread Luiz Capitulino
On Tue, 13 Mar 2012 19:35:24 +0200 Alon Levy al...@redhat.com wrote: On Tue, Mar 13, 2012 at 12:59:17PM -0300, Luiz Capitulino wrote: On Tue, 13 Mar 2012 16:46:12 +0200 Alon Levy al...@redhat.com wrote: On Tue, Mar 13, 2012 at 10:35:55AM -0300, Luiz Capitulino wrote: On Sun, 11 Mar

[Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump

2012-03-11 Thread Alon Levy
Passes the Monitor ptr to the screendump implementation to all for monitor suspend and resume for qxl to fix screendump regression. graphics_console_init signature change required touching every implemented of screen_dump. There is no change other then an added parameter. qxl will make use of it