Re: [Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

2017-09-14 Thread Alistair Francis
On Thu, Sep 14, 2017 at 12:50 AM, Igor Mammedov wrote: > On Thu, 14 Sep 2017 00:47:20 -0300 > Philippe Mathieu-Daudé wrote: > >> Hi Igor, >> >> awesome clean refactor! > Thanks, > > there is more patches on this topic for other targets to post > but it's

Re: [Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

2017-09-14 Thread Alistair Francis
On Wed, Sep 13, 2017 at 9:04 AM, Igor Mammedov wrote: > there are 2 use cases to deal with: > 1: fixed CPU models per board/soc > 2: boards with user configurable cpu_model and fallback to > default cpu_model if user hasn't specified one explicitly > > For the 1st >

Re: [Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

2017-09-14 Thread Igor Mammedov
On Thu, 14 Sep 2017 00:47:20 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > awesome clean refactor! Thanks, there is more patches on this topic for other targets to post but it's waiting on 1-3/5 to land in master so it would be easier for maintainers to verify/test them

Re: [Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

2017-09-13 Thread Philippe Mathieu-Daudé
Hi Igor, awesome clean refactor! just 1 comment inlined. On 09/13/2017 01:04 PM, Igor Mammedov wrote: there are 2 use cases to deal with: 1: fixed CPU models per board/soc 2: boards with user configurable cpu_model and fallback to default cpu_model if user hasn't specified one

[Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

2017-09-13 Thread Igor Mammedov
there are 2 use cases to deal with: 1: fixed CPU models per board/soc 2: boards with user configurable cpu_model and fallback to default cpu_model if user hasn't specified one explicitly For the 1st drop intermediate cpu_model parsing and use const cpu type directly, which replaces: