Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 02:21:32PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: > >> I hate the virtio pointer thicket. > > > > The problem is that each device is both a virtio pci > > device and a virtio n

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: >> I hate the virtio pointer thicket. > > The problem is that each device is both a virtio pci > device and a virtio net device. In my possibly naive opinion, virtio-FOO-pci is a PCI device, and has

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Michael S. Tsirkin
On Thu, Jul 28, 2011 at 09:45:44AM +0200, Markus Armbruster wrote: > I hate the virtio pointer thicket. The problem is that each device is both a virtio pci device and a virtio net device. -- MST

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Amit Shah
On (Thu) 28 Jul 2011 [09:45:44], Markus Armbruster wrote: > Amit Shah writes: > > > Migrating after unplugging a virtio-balloon device resulted in an error > > message on the destination: > > > > Unknown savevm section or instance ':00:04.0/virtio-balloon' 0 > > load of migration failed > > >

Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-28 Thread Markus Armbruster
Amit Shah writes: > Migrating after unplugging a virtio-balloon device resulted in an error > message on the destination: > > Unknown savevm section or instance ':00:04.0/virtio-balloon' 0 > load of migration failed > > Fix this by unregistering the section on device unplug. > > Signed-off-by

[Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

2011-07-27 Thread Amit Shah
Migrating after unplugging a virtio-balloon device resulted in an error message on the destination: Unknown savevm section or instance ':00:04.0/virtio-balloon' 0 load of migration failed Fix this by unregistering the section on device unplug. Signed-off-by: Amit Shah --- hw/virtio-balloon