Re: [Qemu-devel] [PATCH v2 5/6] trace: remove use of event ID enums from APIs

2016-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2016 at 02:20:05PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > On Thu, Sep 15, 2016 at 01:26:06AM +0200, Lluís Vilanova wrote: > >> Daniel P Berrange writes: > >> > >> > Since there will shortly be multiple event groups allowed, > >> > we can no longer use the

Re: [Qemu-devel] [PATCH v2 5/6] trace: remove use of event ID enums from APIs

2016-09-15 Thread Lluís Vilanova
Daniel P Berrange writes: > On Thu, Sep 15, 2016 at 01:26:06AM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > Since there will shortly be multiple event groups allowed, >> > we can no longer use the TraceEventID and TraceEventVCPUID >> > enums in the trace control APIs. There

Re: [Qemu-devel] [PATCH v2 5/6] trace: remove use of event ID enums from APIs

2016-09-15 Thread Daniel P. Berrange
On Thu, Sep 15, 2016 at 01:26:06AM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > Since there will shortly be multiple event groups allowed, > > we can no longer use the TraceEventID and TraceEventVCPUID > > enums in the trace control APIs. There will in fact be > > multiple

Re: [Qemu-devel] [PATCH v2 5/6] trace: remove use of event ID enums from APIs

2016-09-14 Thread Lluís Vilanova
Daniel P Berrange writes: > Since there will shortly be multiple event groups allowed, > we can no longer use the TraceEventID and TraceEventVCPUID > enums in the trace control APIs. There will in fact be > multiple distinct enums, and the enum values will only be > required to be unique per

[Qemu-devel] [PATCH v2 5/6] trace: remove use of event ID enums from APIs

2016-09-14 Thread Daniel P. Berrange
Since there will shortly be multiple event groups allowed, we can no longer use the TraceEventID and TraceEventVCPUID enums in the trace control APIs. There will in fact be multiple distinct enums, and the enum values will only be required to be unique per group. Signed-off-by: Daniel P. Berrange