Re: [Qemu-devel] [PATCH v2 6/8] block: dump_qlist() may dereference a Null pointer

2018-08-31 Thread Eric Blake
On 08/31/2018 11:36 AM, Liam Merwick wrote: A NULL 'list' passed into function dump_qlist() isn't correctly validated and can be passed to qlist_first() where it is dereferenced. Given that dump_qlist() is static, and callers already do the right Double space looks odd. thing, just add an

[Qemu-devel] [PATCH v2 6/8] block: dump_qlist() may dereference a Null pointer

2018-08-31 Thread Liam Merwick
A NULL 'list' passed into function dump_qlist() isn't correctly validated and can be passed to qlist_first() where it is dereferenced. Given that dump_qlist() is static, and callers already do the right thing, just add an assert to catch future potential bugs. Signed-off-by: Liam Merwick ---