Re: [Qemu-devel] [PATCH v2 6/9] qapi: Rewrite string-input-visitor

2018-11-21 Thread Markus Armbruster
David Hildenbrand writes: > On 20.11.18 21:58, Markus Armbruster wrote: >> I think the title should be something like >> >> qapi: Rewrite string-input-visitor's integer and list parsing >> >> because you don't actually rewrite all of it. >> >> Eric Blake writes: >> >>> On 11/20/18 3:25

Re: [Qemu-devel] [PATCH v2 6/9] qapi: Rewrite string-input-visitor

2018-11-21 Thread David Hildenbrand
On 20.11.18 21:58, Markus Armbruster wrote: > I think the title should be something like > > qapi: Rewrite string-input-visitor's integer and list parsing > > because you don't actually rewrite all of it. > > Eric Blake writes: > >> On 11/20/18 3:25 AM, David Hildenbrand wrote: >>> The

Re: [Qemu-devel] [PATCH v2 6/9] qapi: Rewrite string-input-visitor

2018-11-20 Thread Markus Armbruster
I think the title should be something like qapi: Rewrite string-input-visitor's integer and list parsing because you don't actually rewrite all of it. Eric Blake writes: > On 11/20/18 3:25 AM, David Hildenbrand wrote: >> The input visitor has some problems right now, especially >> -

Re: [Qemu-devel] [PATCH v2 6/9] qapi: Rewrite string-input-visitor

2018-11-20 Thread Eric Blake
On 11/20/18 3:25 AM, David Hildenbrand wrote: The input visitor has some problems right now, especially - unsigned type "Range" is used to process signed ranges, resulting in inconsistent behavior and ugly/magical code - uint64_t are parsed like int64_t, so big uint64_t values are not

[Qemu-devel] [PATCH v2 6/9] qapi: Rewrite string-input-visitor

2018-11-20 Thread David Hildenbrand
The input visitor has some problems right now, especially - unsigned type "Range" is used to process signed ranges, resulting in inconsistent behavior and ugly/magical code - uint64_t are parsed like int64_t, so big uint64_t values are not supported and error messages are misleading -