Re: [Qemu-devel] [PATCH v2 62/68] target/arm: Convert T16, Miscellaneous 16-bit instructions

2019-08-26 Thread Richard Henderson
On 8/26/19 1:38 PM, Peter Maydell wrote: >> + IT1011 ... imm:5 cond=%it_cond > > This is correct (same behaviour as the old decoder, but > it looks a bit odd here because it's not the same as > the fields defined by the architecture (in particular the > 'cond' field

Re: [Qemu-devel] [PATCH v2 62/68] target/arm: Convert T16, Miscellaneous 16-bit instructions

2019-08-26 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > diff --git a/target/arm/t16.decode b/target/arm/t16.decode > index 98d60952a1..4ecbabd364 100644 > --- a/target/arm/t16.decode > +++ b/target/arm/t16.decode > @@ -210,20 +210,33 @@ REVSH

[Qemu-devel] [PATCH v2 62/68] target/arm: Convert T16, Miscellaneous 16-bit instructions

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 109 - target/arm/t16.decode | 31 2 files changed, 54 insertions(+), 86 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 941266df14..dc670c9724