Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command

2011-07-12 Thread Jes Sorensen
On 07/11/11 22:35, Luiz Capitulino wrote: Sorry that is no go, you just broke the hmp implementation - you cannot change the hmp behavior like that. HMP uses positional arguments, so changing argument names makes no difference. And, apart from some exceptions, it's not an stable interface,

Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command

2011-07-12 Thread Luiz Capitulino
On Tue, 12 Jul 2011 11:26:09 +0200 Jes Sorensen jes.soren...@redhat.com wrote: On 07/11/11 22:35, Luiz Capitulino wrote: Sorry that is no go, you just broke the hmp implementation - you cannot change the hmp behavior like that. HMP uses positional arguments, so changing argument names

[Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command

2011-07-11 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Add QMP bits for snapshot_blkdev command. This is the same as snapshot_blkdev in the human monitor. The command is synchronous. In the future async commands and or a break down of the functionality into multiple commands might be added. Signed-off-by:

Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command

2011-07-11 Thread Luiz Capitulino
On Mon, 11 Jul 2011 20:01:09 +0200 jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Add QMP bits for snapshot_blkdev command. This is the same as snapshot_blkdev in the human monitor. The command is synchronous. In the future async commands and or a break down of

Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command

2011-07-11 Thread Jes Sorensen
On 07/11/11 22:24, Luiz Capitulino wrote: On Mon, 11 Jul 2011 20:01:09 +0200 jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Add QMP bits for snapshot_blkdev command. This is the same as snapshot_blkdev in the human monitor. The command is synchronous.

Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command

2011-07-11 Thread Luiz Capitulino
On Mon, 11 Jul 2011 22:28:57 +0200 Jes Sorensen jes.soren...@redhat.com wrote: On 07/11/11 22:24, Luiz Capitulino wrote: On Mon, 11 Jul 2011 20:01:09 +0200 jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Add QMP bits for snapshot_blkdev command. This is

[Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command

2011-04-28 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Add QMP bits for snapshot_blkdev command. This is the same as snapshot_blkdev in the human monitor. The command is synchronous. In the future async commands may be added with the name _async/-async. Signed-off-by: Jes Sorensen jes.soren...@redhat.com