Re: [Qemu-devel] [PATCH v3] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2020-02-13 Thread Jason Wang
On 2020/2/13 下午5:39, Bin Meng wrote: Hi Jason, On Mon, Aug 19, 2019 at 1:40 PM Jason Wang wrote: On 2019/8/19 下午1:24, Bin Meng wrote: On Sat, Aug 10, 2019 at 9:58 AM Alistair Francis wrote: On Fri, Aug 9, 2019 at 12:26 AM Bin Meng wrote: When CADENCE_GEM_ERR_DEBUG is turned on, there

Re: [Qemu-devel] [PATCH v3] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2020-02-13 Thread Bin Meng
Hi Jason, On Mon, Aug 19, 2019 at 1:40 PM Jason Wang wrote: > > > On 2019/8/19 下午1:24, Bin Meng wrote: > > On Sat, Aug 10, 2019 at 9:58 AM Alistair Francis > > wrote: > >> On Fri, Aug 9, 2019 at 12:26 AM Bin Meng wrote: > >>> When CADENCE_GEM_ERR_DEBUG is turned on, there are several > >>>

Re: [Qemu-devel] [PATCH v3] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-18 Thread Jason Wang
On 2019/8/19 下午1:24, Bin Meng wrote: > On Sat, Aug 10, 2019 at 9:58 AM Alistair Francis wrote: >> On Fri, Aug 9, 2019 at 12:26 AM Bin Meng wrote: >>> When CADENCE_GEM_ERR_DEBUG is turned on, there are several >>> compilation errors in DB_PRINT(). Fix them. >>> >>> While we are here, update to

Re: [Qemu-devel] [PATCH v3] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-18 Thread Bin Meng
On Sat, Aug 10, 2019 at 9:58 AM Alistair Francis wrote: > > On Fri, Aug 9, 2019 at 12:26 AM Bin Meng wrote: > > > > When CADENCE_GEM_ERR_DEBUG is turned on, there are several > > compilation errors in DB_PRINT(). Fix them. > > > > While we are here, update to use appropriate modifiers in > > the

Re: [Qemu-devel] [PATCH v3] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-09 Thread Alistair Francis
On Fri, Aug 9, 2019 at 12:26 AM Bin Meng wrote: > > When CADENCE_GEM_ERR_DEBUG is turned on, there are several > compilation errors in DB_PRINT(). Fix them. > > While we are here, update to use appropriate modifiers in > the same DB_PRINT() call. > > Signed-off-by: Bin Meng Reviewed-by:

[Qemu-devel] [PATCH v3] hw: net: cadence_gem: Fix build errors in DB_PRINT()

2019-08-09 Thread Bin Meng
When CADENCE_GEM_ERR_DEBUG is turned on, there are several compilation errors in DB_PRINT(). Fix them. While we are here, update to use appropriate modifiers in the same DB_PRINT() call. Signed-off-by: Bin Meng --- Changes in v3: - use PRIx64 as rx_desc_get_buffer() returns uint64_t - use %u