Re: [Qemu-devel] [PATCH v3] net: don't poke at chardev internal QemuOpts

2016-10-07 Thread Marc-André Lureau
Hi On Fri, Oct 7, 2016 at 4:18 PM Daniel P. Berrange wrote: > The vhost-user & colo code is poking at the QemuOpts instance > in the CharDriverState struct, not realizing that it is valid > for this to be NULL. e.g. the following crash shows a codepath > where it will be

[Qemu-devel] [PATCH v3] net: don't poke at chardev internal QemuOpts

2016-10-07 Thread Daniel P. Berrange
The vhost-user & colo code is poking at the QemuOpts instance in the CharDriverState struct, not realizing that it is valid for this to be NULL. e.g. the following crash shows a codepath where it will be NULL: Program terminated with signal SIGSEGV, Segmentation fault. #0 0x55baf6ab4adc in