Re: [Qemu-devel] [PATCH v3] os: don't corrupt pre-existing memory-backend data with prealloc

2017-03-10 Thread Paolo Bonzini
On 10/03/2017 05:30, Stefan Hajnoczi wrote: > On Fri, Mar 03, 2017 at 11:32:55AM +, Daniel P. Berrange wrote: >> When using a memory-backend object with prealloc turned on, QEMU >> will memset() the first byte in every memory page to zero. While >> this might have been acceptable for memory b

Re: [Qemu-devel] [PATCH v3] os: don't corrupt pre-existing memory-backend data with prealloc

2017-03-09 Thread Stefan Hajnoczi
On Fri, Mar 03, 2017 at 11:32:55AM +, Daniel P. Berrange wrote: > When using a memory-backend object with prealloc turned on, QEMU > will memset() the first byte in every memory page to zero. While > this might have been acceptable for memory backends associated > with RAM, this corrupts applic

Re: [Qemu-devel] [PATCH v3] os: don't corrupt pre-existing memory-backend data with prealloc

2017-03-09 Thread Stefan Hajnoczi
On Fri, Mar 03, 2017 at 11:32:55AM +, Daniel P. Berrange wrote: > When using a memory-backend object with prealloc turned on, QEMU > will memset() the first byte in every memory page to zero. While > this might have been acceptable for memory backends associated > with RAM, this corrupts applic

Re: [Qemu-devel] [PATCH v3] os: don't corrupt pre-existing memory-backend data with prealloc

2017-03-03 Thread Andrea Arcangeli
On Fri, Mar 03, 2017 at 11:32:55AM +, Daniel P. Berrange wrote: > When using a memory-backend object with prealloc turned on, QEMU > will memset() the first byte in every memory page to zero. While > this might have been acceptable for memory backends associated > with RAM, this corrupts applic

Re: [Qemu-devel] [PATCH v3] os: don't corrupt pre-existing memory-backend data with prealloc

2017-03-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170303113255.28262-1-berra...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v3] os: don't corrupt pre-existing memory-backend data with prealloc === TEST SCRIPT

[Qemu-devel] [PATCH v3] os: don't corrupt pre-existing memory-backend data with prealloc

2017-03-03 Thread Daniel P. Berrange
When using a memory-backend object with prealloc turned on, QEMU will memset() the first byte in every memory page to zero. While this might have been acceptable for memory backends associated with RAM, this corrupts application data for NVDIMMs. Instead of setting every page to zero, read the cur