Lluís Vilanova vilan...@ac.upc.edu writes:
Eric Blake writes:
On 08/21/2014 11:52 AM, Lluís Vilanova wrote:
Also removes old trace-event, trace-file and info trace-events HMP
commands.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 24 +++-
Markus Armbruster writes:
Lluís Vilanova vilan...@ac.upc.edu writes:
Eric Blake writes:
On 08/21/2014 11:52 AM, Lluís Vilanova wrote:
[...]
+#
+# Since 2.2
+##
+{ 'command': 'trace-event-set-state',
+ 'data': {'name': 'str', 'state': 'bool', '*keepgoing': 'bool'} }
This only lets me
On Thu, Aug 21, 2014 at 07:52:37PM +0200, Lluís Vilanova wrote:
Also removes old trace-event, trace-file and info trace-events HMP
commands.
Is this commit description correct? I think we don't want to remove
HMP commands. It is legacy but users may still rely on HMP. It's
certainly used for
Lluís Vilanova vilan...@ac.upc.edu writes:
Also removes old trace-event, trace-file and info trace-events HMP
commands.
I can't see any HMP commands removal in your patch. You
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 24 +++-
On 08/21/2014 11:52 AM, Lluís Vilanova wrote:
Also removes old trace-event, trace-file and info trace-events HMP
commands.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 24 +++-
qapi-schema.json|3 ++
qapi/trace.json | 44
Eric Blake writes:
On 08/21/2014 11:52 AM, Lluís Vilanova wrote:
Also removes old trace-event, trace-file and info trace-events HMP
commands.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 24 +++-
qapi-schema.json|3 ++
qapi/trace.json
Markus Armbruster writes:
Lluís Vilanova vilan...@ac.upc.edu writes:
Also removes old trace-event, trace-file and info trace-events HMP
commands.
I can't see any HMP commands removal in your patch. You
Sorry, I forgot to remove that from the commit message.
Signed-off-by: Lluís
Stefan Hajnoczi writes:
On Thu, Aug 21, 2014 at 07:52:37PM +0200, Lluís Vilanova wrote:
Also removes old trace-event, trace-file and info trace-events HMP
commands.
Is this commit description correct? I think we don't want to remove
HMP commands. It is legacy but users may still rely on
On 08/22/2014 12:16 PM, Lluís Vilanova wrote:
+# @name: Event name.
+# @sstatic: Static tracing state.
+# @sdynamic: Dynamic tracing state.
Does the leading 's' add any value? QAPI doesn't have to use obscure
abbreviations.
It felt wrong to have a JSON attribute named differently from
Also removes old trace-event, trace-file and info trace-events HMP
commands.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 24 +++-
qapi-schema.json|3 ++
qapi/trace.json | 44 +
qmp-commands.hx | 27
10 matches
Mail list logo