Re: [Qemu-devel] [PATCH v3 0/2] Produce better termination message

2016-09-26 Thread Paolo Bonzini
On 26/09/2016 11:02, Michal Privoznik wrote: > Huh, this has beacame more hairy than I initially thought. An > alternative suggestion might be to not call PID->name translate function > from the signal handler, but call it just from the qemu_kill_report(). > Yes, this will increase the chances

Re: [Qemu-devel] [PATCH v3 0/2] Produce better termination message

2016-09-26 Thread Michal Privoznik
On 22.09.2016 18:43, Paolo Bonzini wrote: > > > On 21/09/2016 18:27, Michal Privoznik wrote: >> This is v2 of: >> http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg05058.html >> >> Diff to v2: >> - In 1/2 I've dropped stdio funcs in favour of g_file_get_contents() (thanks >> Dan!) >>

Re: [Qemu-devel] [PATCH v3 0/2] Produce better termination message

2016-09-22 Thread Paolo Bonzini
On 21/09/2016 18:27, Michal Privoznik wrote: > This is v2 of: > http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg05058.html > > Diff to v2: > - In 1/2 I've dropped stdio funcs in favour of g_file_get_contents() (thanks > Dan!) > > Michal Privoznik (2): > util: Introduce

Re: [Qemu-devel] [PATCH v3 0/2] Produce better termination message

2016-09-21 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: cover.1474475100.git.mpriv...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/2] Produce better

Re: [Qemu-devel] [PATCH v3 0/2] Produce better termination message

2016-09-21 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1474475100.git.mpriv...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/2] Produce better termination message === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

[Qemu-devel] [PATCH v3 0/2] Produce better termination message

2016-09-21 Thread Michal Privoznik
This is v2 of: http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg05058.html Diff to v2: - In 1/2 I've dropped stdio funcs in favour of g_file_get_contents() (thanks Dan!) Michal Privoznik (2): util: Introduce qemu_get_pid_name qemu_kill_report: Report PID name too