Re: [Qemu-devel] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll

2017-05-18 Thread Richard W.M. Jones
On Mon, May 15, 2017 at 12:00:52PM +0200, Paolo Bonzini wrote: > Compared to v2, this silences checkpatch and correctly destroy the mutex on > exiting from curl_open with an error. FWIW I hit the curl bug again and tested the current patch series, and it also fixes the bug (as expected). Rich. -

Re: [Qemu-devel] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll

2017-05-16 Thread Jeff Cody
On Mon, May 15, 2017 at 12:00:52PM +0200, Paolo Bonzini wrote: > Compared to v2, this silences checkpatch and correctly destroy the mutex on > exiting from curl_open with an error. > > Paolo > > Paolo Bonzini (7): > curl: strengthen assertion in curl_clean_state > curl: never invoke callbacks

Re: [Qemu-devel] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll

2017-05-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll Message-id: 20170515100059.15795-1-pbonz...@redhat.com Type: series === TEST SCRIPT BEGIN

[Qemu-devel] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll

2017-05-15 Thread Paolo Bonzini
Compared to v2, this silences checkpatch and correctly destroy the mutex on exiting from curl_open with an error. Paolo Paolo Bonzini (7): curl: strengthen assertion in curl_clean_state curl: never invoke callbacks with s->mutex held curl: avoid recursive locking of BDRVCURLState mutex cu