Re: [Qemu-devel] [PATCH v3 01/20] virtio: mmio-v1: Validate queue PFN

2018-07-03 Thread Michael S. Tsirkin
On Tue, Jul 03, 2018 at 09:04:01AM +0100, Suzuki K Poulose wrote: > Hi Michael, > > On 06/29/2018 06:42 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 29, 2018 at 12:15:21PM +0100, Suzuki K Poulose wrote: > > > virtio-mmio with virtio-v1 uses a 32bit PFN for the queue. > > > If the queue pfn is

Re: [Qemu-devel] [PATCH v3 01/20] virtio: mmio-v1: Validate queue PFN

2018-07-03 Thread Suzuki K Poulose
Hi Michael, On 06/29/2018 06:42 PM, Michael S. Tsirkin wrote: On Fri, Jun 29, 2018 at 12:15:21PM +0100, Suzuki K Poulose wrote: virtio-mmio with virtio-v1 uses a 32bit PFN for the queue. If the queue pfn is too large to fit in 32bits, which we could hit on arm64 systems with 52bit physical

Re: [Qemu-devel] [PATCH v3 01/20] virtio: mmio-v1: Validate queue PFN

2018-06-29 Thread Michael S. Tsirkin
On Fri, Jun 29, 2018 at 12:15:21PM +0100, Suzuki K Poulose wrote: > virtio-mmio with virtio-v1 uses a 32bit PFN for the queue. > If the queue pfn is too large to fit in 32bits, which > we could hit on arm64 systems with 52bit physical addresses > (even with 64K page size), we simply miss out a

[Qemu-devel] [PATCH v3 01/20] virtio: mmio-v1: Validate queue PFN

2018-06-29 Thread Suzuki K Poulose
virtio-mmio with virtio-v1 uses a 32bit PFN for the queue. If the queue pfn is too large to fit in 32bits, which we could hit on arm64 systems with 52bit physical addresses (even with 64K page size), we simply miss out a proper link to the other side of the queue. Add a check to validate the PFN,