Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-04-12 Thread Liu, Yi L
Hi David, > From: David Gibson [mailto:da...@gibson.dropbear.id.au] > Sent: Thursday, April 12, 2018 10:36 AM > On Tue, Mar 06, 2018 at 06:33:52PM +0800, Liu, Yi L wrote: > > On Mon, Mar 05, 2018 at 02:31:44PM +1100, David Gibson wrote: > > > On Thu, Mar 01, 2018 at 06:31:55PM +0800, Liu, Yi L

Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-04-11 Thread David Gibson
On Tue, Mar 06, 2018 at 06:33:52PM +0800, Liu, Yi L wrote: > On Mon, Mar 05, 2018 at 02:31:44PM +1100, David Gibson wrote: > > On Thu, Mar 01, 2018 at 06:31:55PM +0800, Liu, Yi L wrote: > > > This patch intoduces PCISVAOps for virt-SVA. > > > > > > So far, to setup virt-SVA for assigned SVA

Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-03-06 Thread Liu, Yi L
On Mon, Mar 05, 2018 at 02:31:44PM +1100, David Gibson wrote: > On Thu, Mar 01, 2018 at 06:31:55PM +0800, Liu, Yi L wrote: > > This patch intoduces PCISVAOps for virt-SVA. > > > > So far, to setup virt-SVA for assigned SVA capable device, needs to > > config host translation structures. e.g. for

Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-03-05 Thread Liu, Yi L
On Fri, Mar 02, 2018 at 04:10:48PM +0100, Paolo Bonzini wrote: > On 01/03/2018 11:33, Liu, Yi L wrote: > > +void pci_setup_sva_ops(PCIDevice *dev, PCISVAOps *ops) > > +{ > > +if (dev) { > > +dev->sva_ops = ops; > > +} > > +return; > > +} > > + > > Better: > > { >

Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-03-04 Thread David Gibson
On Thu, Mar 01, 2018 at 06:31:55PM +0800, Liu, Yi L wrote: > This patch intoduces PCISVAOps for virt-SVA. > > So far, to setup virt-SVA for assigned SVA capable device, needs to > config host translation structures. e.g. for VT-d, needs to set the > guest pasid table to host and enable nested

Re: [Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-03-02 Thread Paolo Bonzini
On 01/03/2018 11:33, Liu, Yi L wrote: > +void pci_setup_sva_ops(PCIDevice *dev, PCISVAOps *ops) > +{ > +if (dev) { > +dev->sva_ops = ops; > +} > +return; > +} > + Better: { assert(ops && !dev->sva_ops); dev->sva_ops = ops; }

[Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-03-01 Thread Liu, Yi L
This patch intoduces PCISVAOps for virt-SVA. So far, to setup virt-SVA for assigned SVA capable device, needs to config host translation structures. e.g. for VT-d, needs to set the guest pasid table to host and enable nested translation. Besides, vIOMMU emulator needs to forward guest's cache

[Qemu-devel] [PATCH v3 05/12] hw/pci: introduce PCISVAOps to PCIDevice

2018-03-01 Thread Liu, Yi L
This patch intoduces PCISVAOps for virt-SVA. So far, to setup virt-SVA for assigned SVA capable device, needs to config host translation structures. e.g. for VT-d, needs to set the guest pasid table to host and enable nested translation. Besides, vIOMMU emulator needs to forward guest's cache