Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-07-02 Thread Stefan Berger
On 06/22/2012 07:06 AM, Amit Shah wrote: On (Wed) 20 Jun 2012 [16:29:22], Anthony Liguori wrote: On 06/20/2012 01:59 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When the guest asks for entropy from the virtio hwrng, it puts a

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: On 06/22/2012 01:50 PM, Amit Shah wrote: On (Fri) 22 Jun 2012 [08:44:52], Anthony Liguori wrote: On 06/22/2012 08:34 AM, Daniel P. Berrange wrote: Oh, that's a good point. But easily fixed. Of course, except that now we

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Anthony Liguori
On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: On 06/22/2012 01:50 PM, Amit Shah wrote: On (Fri) 22 Jun 2012 [08:44:52], Anthony Liguori wrote: On 06/22/2012 08:34 AM, Daniel P. Berrange wrote: Oh, that's a good point.

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 07:22:13AM -0500, Anthony Liguori wrote: On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: On 06/22/2012 01:50 PM, Amit Shah wrote: On (Fri) 22 Jun 2012 [08:44:52], Anthony Liguori wrote: On 06/22/2012

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Anthony Liguori
On 06/25/2012 07:30 AM, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 07:22:13AM -0500, Anthony Liguori wrote: On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote: On 06/22/2012 01:50 PM, Amit Shah wrote: On (Fri) 22 Jun 2012

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-25 Thread Daniel P. Berrange
On Mon, Jun 25, 2012 at 07:54:18AM -0500, Anthony Liguori wrote: On 06/25/2012 07:30 AM, Daniel P. Berrange wrote: On Mon, Jun 25, 2012 at 07:22:13AM -0500, Anthony Liguori wrote: On 06/25/2012 07:10 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 02:59:13PM -0500, Anthony Liguori wrote:

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Amit Shah
On (Wed) 20 Jun 2012 [16:29:22], Anthony Liguori wrote: On 06/20/2012 01:59 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When the guest asks for entropy from the virtio hwrng, it puts a buffer in the vq. We then put entropy into

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 06/20/2012 01:59 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When the guest asks for entropy from the virtio hwrng, it puts a buffer in the vq. We then put entropy into that

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Anthony Liguori
On 06/22/2012 07:12 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: Nack. Use a protocol. This is not what QMP events are designed for! No human is going to launch nc to a unix domain socket to launch QEMU. That's a silly use-case to design for. To be honest, I'm

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 07:22:51AM -0500, Anthony Liguori wrote: On 06/22/2012 07:12 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: Nack. Use a protocol. This is not what QMP events are designed for! No human is going to launch nc to a unix domain socket to

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Anthony Liguori
On 06/22/2012 07:31 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 07:22:51AM -0500, Anthony Liguori wrote: On 06/22/2012 07:12 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: Nack. Use a protocol. This is not what QMP events are designed for! No human is

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Daniel P. Berrange
On Fri, Jun 22, 2012 at 07:58:53AM -0500, Anthony Liguori wrote: On 06/22/2012 07:31 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 07:22:51AM -0500, Anthony Liguori wrote: On 06/22/2012 07:12 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: Nack. Use a

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Anthony Liguori
On 06/22/2012 08:34 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 07:58:53AM -0500, Anthony Liguori wrote: On 06/22/2012 07:31 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 07:22:51AM -0500, Anthony Liguori wrote: On 06/22/2012 07:12 AM, Markus Armbruster wrote: Anthony

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Amit Shah
On (Fri) 22 Jun 2012 [08:44:52], Anthony Liguori wrote: On 06/22/2012 08:34 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 07:58:53AM -0500, Anthony Liguori wrote: On 06/22/2012 07:31 AM, Daniel P. Berrange wrote: On Fri, Jun 22, 2012 at 07:22:51AM -0500, Anthony Liguori wrote: On

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-22 Thread Anthony Liguori
On 06/22/2012 01:50 PM, Amit Shah wrote: On (Fri) 22 Jun 2012 [08:44:52], Anthony Liguori wrote: On 06/22/2012 08:34 AM, Daniel P. Berrange wrote: Oh, that's a good point. But easily fixed. Of course, except that now we have to maintain compatibility so some hideous hack goes in. This

[Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-20 Thread Amit Shah
The Linux kernel already has a virtio-rng driver, this is the device implementation. When the guest asks for entropy from the virtio hwrng, it puts a buffer in the vq. We then put entropy into that buffer, and push it back to the guest. The chardev connected to this device is fed the data to be

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-20 Thread Daniel P. Berrange
On Wed, Jun 20, 2012 at 12:29:32PM +0530, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When the guest asks for entropy from the virtio hwrng, it puts a buffer in the vq. We then put entropy into that buffer, and push it back to the

Re: [Qemu-devel] [PATCH v3 1/1] virtio-rng: hardware random number generator device

2012-06-20 Thread Anthony Liguori
On 06/20/2012 01:59 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When the guest asks for entropy from the virtio hwrng, it puts a buffer in the vq. We then put entropy into that buffer, and push it back to the guest. The chardev