Re: [Qemu-devel] [PATCH v3 1/2] move vm_start to cpus.c

2017-01-25 Thread Paolo Bonzini
On 25/01/2017 18:53, Claudio Imbrenda wrote: > On 25/01/17 11:21, Paolo Bonzini wrote: >> >> >> On 28/10/2016 19:15, Claudio Imbrenda wrote: >>> * moves the call to qemu_clock_enable away from resume_all_vcpus, and >>> add an explicit call to it before each instance of resume_all_vcpus >>> in

Re: [Qemu-devel] [PATCH v3 1/2] move vm_start to cpus.c

2017-01-25 Thread Claudio Imbrenda
On 25/01/17 11:21, Paolo Bonzini wrote: > > > On 28/10/2016 19:15, Claudio Imbrenda wrote: >> * moves the call to qemu_clock_enable away from resume_all_vcpus, and >> add an explicit call to it before each instance of resume_all_vcpus >> in the code. > > This change adds useless duplication,

Re: [Qemu-devel] [PATCH v3 1/2] move vm_start to cpus.c

2017-01-25 Thread Paolo Bonzini
On 28/10/2016 19:15, Claudio Imbrenda wrote: > * moves the call to qemu_clock_enable away from resume_all_vcpus, and > add an explicit call to it before each instance of resume_all_vcpus > in the code. This change adds useless duplication, and isn't matched by a similar change to pause_all_v

[Qemu-devel] [PATCH v3 1/2] move vm_start to cpus.c

2016-10-28 Thread Claudio Imbrenda
This patch: * moves vm_start to cpus.c . * exports qemu_vmstop_requested, since it's needed by vm_start . * extracts vm_prepare_start from vm_start; it does what vm_start did, except restarting the cpus. vm_start now calls vm_prepare_start. * moves the call to qemu_clock_enable away from resume_