Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-06-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 05/23/2013 03:07 AM, Amos Kong wrote: Introduce this new QMP event to notify management after guest changes rx-filter configuration. Signed-off-by: Amos Kong ak...@redhat.com --- QMP/qmp-events.txt| 14 ++

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 08:54:46 +0200 Markus Armbruster arm...@redhat.com wrote: Eric Blake ebl...@redhat.com writes: On 05/23/2013 03:07 AM, Amos Kong wrote: Introduce this new QMP event to notify management after guest changes rx-filter configuration. Signed-off-by: Amos Kong

[Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Amos Kong
Introduce this new QMP event to notify management after guest changes rx-filter configuration. Signed-off-by: Amos Kong ak...@redhat.com --- QMP/qmp-events.txt| 14 ++ include/monitor/monitor.h | 1 + monitor.c | 1 + 3 files changed, 16 insertions(+) diff

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Michael S. Tsirkin
On Thu, May 23, 2013 at 05:07:59PM +0800, Amos Kong wrote: Introduce this new QMP event to notify management after guest changes rx-filter configuration. Signed-off-by: Amos Kong ak...@redhat.com --- QMP/qmp-events.txt| 14 ++ include/monitor/monitor.h | 1 +

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Eric Blake
On 05/23/2013 03:07 AM, Amos Kong wrote: Introduce this new QMP event to notify management after guest changes rx-filter configuration. Signed-off-by: Amos Kong ak...@redhat.com --- QMP/qmp-events.txt| 14 ++ include/monitor/monitor.h | 1 + monitor.c

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 13:24:59 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 05:07:59PM +0800, Amos Kong wrote: Introduce this new QMP event to notify management after guest changes rx-filter configuration. Signed-off-by: Amos Kong ak...@redhat.com ---

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Michael S. Tsirkin
On Thu, May 23, 2013 at 10:28:42AM -0400, Luiz Capitulino wrote: On Thu, 23 May 2013 13:24:59 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 05:07:59PM +0800, Amos Kong wrote: Introduce this new QMP event to notify management after guest changes rx-filter

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Eric Blake
On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote: Please stress this is only for the NIC. It does not apply to non-NIC netclients. Stress it in the event name too, please. I find RX_FILTER_CHANGED a bit generic. What do you suggest? NIC_RX_FILTER_CHANGED ? Yes, that might work. (And

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Michael S. Tsirkin
On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote: On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote: Please stress this is only for the NIC. It does not apply to non-NIC netclients. Stress it in the event name too, please. I find RX_FILTER_CHANGED a bit generic. What do

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 17:57:56 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote: On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote: Please stress this is only for the NIC. It does not apply to non-NIC netclients. Stress it in

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-05-23 Thread Amos Kong
On Thu, May 23, 2013 at 11:33:37AM -0400, Luiz Capitulino wrote: On Thu, 23 May 2013 17:57:56 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, May 23, 2013 at 08:52:16AM -0600, Eric Blake wrote: On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote: Please stress this is only for