Re: [Qemu-devel] [PATCH v3 1/3] e1000: allow command-line selection of card model

2014-06-02 Thread Stefan Hajnoczi
On Sat, May 31, 2014 at 11:33:14PM -0400, Gabriel L. Somlo wrote: @@ -151,10 +141,21 @@ typedef struct E1000State_st { uint32_t compat_flags; } E1000State; -#define TYPE_E1000 e1000 +typedef struct E1000DeviceClass { The QOM type is called TYPE_E1000_BASE (e1000-base), please name

Re: [Qemu-devel] [PATCH v3 1/3] e1000: allow command-line selection of card model

2014-06-01 Thread Michael S. Tsirkin
On Sat, May 31, 2014 at 11:33:14PM -0400, Gabriel L. Somlo wrote: Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. Signed-off-by: Romain Dolbeau rom...@dolbeau.org Signed-off-by: Gabriel Somlo so...@cmu.edu ---

Re: [Qemu-devel] [PATCH v3 1/3] e1000: allow command-line selection of card model

2014-06-01 Thread Peter Crosthwaite
On Sun, Jun 1, 2014 at 1:33 PM, Gabriel L. Somlo gso...@gmail.com wrote: Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. Signed-off-by: Romain Dolbeau rom...@dolbeau.org Signed-off-by: Gabriel Somlo so...@cmu.edu Reviewed-by:

[Qemu-devel] [PATCH v3 1/3] e1000: allow command-line selection of card model

2014-05-31 Thread Gabriel L. Somlo
Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. Signed-off-by: Romain Dolbeau rom...@dolbeau.org Signed-off-by: Gabriel Somlo so...@cmu.edu --- hw/net/e1000.c | 120 +---