Re: [Qemu-devel] [PATCH v3 1/3] qemu-io: Return non-zero exit code on failure

2017-01-31 Thread Nir Soffer
On Mon, Jan 30, 2017 at 6:44 PM, Eric Blake wrote: > On 01/27/2017 09:59 PM, Nir Soffer wrote: >> From: Nir Soffer >> >> The result of openfile was not checked, leading to failure deep in the >> actual command with confusing error message, and exiting with

Re: [Qemu-devel] [PATCH v3 1/3] qemu-io: Return non-zero exit code on failure

2017-01-30 Thread Eric Blake
On 01/27/2017 09:59 PM, Nir Soffer wrote: > From: Nir Soffer > > The result of openfile was not checked, leading to failure deep in the > actual command with confusing error message, and exiting with exit code 0. > When posting a series, please ensure that your messages are

[Qemu-devel] [PATCH v3 1/3] qemu-io: Return non-zero exit code on failure

2017-01-30 Thread Nir Soffer
From: Nir Soffer The result of openfile was not checked, leading to failure deep in the actual command with confusing error message, and exiting with exit code 0. Here is a simple example - trying to read with the wrong format: $ touch file $ qemu-io -f qcow2 -c

[Qemu-devel] [PATCH v3 1/3] qemu-io: Return non-zero exit code on failure

2017-01-27 Thread Nir Soffer
From: Nir Soffer The result of openfile was not checked, leading to failure deep in the actual command with confusing error message, and exiting with exit code 0. Here is a simple example - trying to read with the wrong format: $ touch file $ qemu-io -f qcow2 -c