Re: [Qemu-devel] [PATCH v3 1/5] block/dirty-bitmaps: add user_modifiable status checker

2018-09-27 Thread John Snow
On 09/26/2018 10:17 PM, Eric Blake wrote: > On 9/26/18 6:53 AM, Vladimir Sementsov-Ogievskiy wrote: >> 26.09.2018 02:49, John Snow wrote: >>> Instead of both frozen and qmp_locked checks, wrap it into one check. >>> frozen implies the bitmap is split in two (for backup), and shouldn't >>> be

Re: [Qemu-devel] [PATCH v3 1/5] block/dirty-bitmaps: add user_modifiable status checker

2018-09-26 Thread Eric Blake
On 9/26/18 7:19 AM, Vladimir Sementsov-Ogievskiy wrote: 26.09.2018 14:53, Vladimir Sementsov-Ogievskiy wrote: 26.09.2018 02:49, John Snow wrote: Instead of both frozen and qmp_locked checks, wrap it into one check. frozen implies the bitmap is split in two (for backup), and shouldn't be

Re: [Qemu-devel] [PATCH v3 1/5] block/dirty-bitmaps: add user_modifiable status checker

2018-09-26 Thread Eric Blake
On 9/26/18 6:53 AM, Vladimir Sementsov-Ogievskiy wrote: 26.09.2018 02:49, John Snow wrote: Instead of both frozen and qmp_locked checks, wrap it into one check. frozen implies the bitmap is split in two (for backup), and shouldn't be modified. qmp_locked implies it's being used by another

Re: [Qemu-devel] [PATCH v3 1/5] block/dirty-bitmaps: add user_modifiable status checker

2018-09-26 Thread Vladimir Sementsov-Ogievskiy
26.09.2018 14:53, Vladimir Sementsov-Ogievskiy wrote: 26.09.2018 02:49, John Snow wrote: Instead of both frozen and qmp_locked checks, wrap it into one check. frozen implies the bitmap is split in two (for backup), and shouldn't be modified. qmp_locked implies it's being used by another

Re: [Qemu-devel] [PATCH v3 1/5] block/dirty-bitmaps: add user_modifiable status checker

2018-09-26 Thread Vladimir Sementsov-Ogievskiy
26.09.2018 02:49, John Snow wrote: Instead of both frozen and qmp_locked checks, wrap it into one check. frozen implies the bitmap is split in two (for backup), and shouldn't be modified. qmp_locked implies it's being used by another operation, like being exported over NBD. In both cases it

[Qemu-devel] [PATCH v3 1/5] block/dirty-bitmaps: add user_modifiable status checker

2018-09-25 Thread John Snow
Instead of both frozen and qmp_locked checks, wrap it into one check. frozen implies the bitmap is split in two (for backup), and shouldn't be modified. qmp_locked implies it's being used by another operation, like being exported over NBD. In both cases it means we shouldn't allow the user to