Re: [Qemu-devel] [PATCH v3 1/5] hw/i386: allow SHPC for Q35 machine

2017-08-03 Thread Marcel Apfelbaum
On 03/08/2017 15:52, Michael S. Tsirkin wrote: On Sat, Jul 29, 2017 at 02:37:49AM +0300, Aleksandr Bezzubikov wrote: Unmask previously masked SHPC feature in _OSC method. Signed-off-by: Aleksandr Bezzubikov Hi Michael, This does not do what the subject says - it

Re: [Qemu-devel] [PATCH v3 1/5] hw/i386: allow SHPC for Q35 machine

2017-08-03 Thread Alexander Bezzubikov
чт, 3 авг. 2017 г. в 15:52, Michael S. Tsirkin : > On Sat, Jul 29, 2017 at 02:37:49AM +0300, Aleksandr Bezzubikov wrote: > > Unmask previously masked SHPC feature in _OSC method. > > > > Signed-off-by: Aleksandr Bezzubikov > > This does not do what the

Re: [Qemu-devel] [PATCH v3 1/5] hw/i386: allow SHPC for Q35 machine

2017-08-03 Thread Michael S. Tsirkin
On Sat, Jul 29, 2017 at 02:37:49AM +0300, Aleksandr Bezzubikov wrote: > Unmask previously masked SHPC feature in _OSC method. > > Signed-off-by: Aleksandr Bezzubikov This does not do what the subject says - it enables SHPC unconditionally. And I think it will actually break

Re: [Qemu-devel] [PATCH v3 1/5] hw/i386: allow SHPC for Q35 machine

2017-07-31 Thread Marcel Apfelbaum
On 29/07/2017 2:37, Aleksandr Bezzubikov wrote: Unmask previously masked SHPC feature in _OSC method. Signed-off-by: Aleksandr Bezzubikov --- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c

[Qemu-devel] [PATCH v3 1/5] hw/i386: allow SHPC for Q35 machine

2017-07-28 Thread Aleksandr Bezzubikov
Unmask previously masked SHPC feature in _OSC method. Signed-off-by: Aleksandr Bezzubikov --- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6b7bade..2ab32f9 100644 ---