Re: [Qemu-devel] [PATCH v3 1/8] apic: add global apic_get_class()

2016-10-04 Thread Eduardo Habkost
On Tue, Oct 04, 2016 at 03:38:01PM +0200, Radim Krčmář wrote: > 2016-10-03 13:03-0300, Eduardo Habkost: > > On Fri, Sep 30, 2016 at 06:10:06PM +0200, Radim Krčmář wrote: [...] > >> +static void x86_cpu_apic_create(X86CPU *cpu, Error **errp) > >> +{ > >> +APICCommonState *apic; > >> +ObjectC

Re: [Qemu-devel] [PATCH v3 1/8] apic: add global apic_get_class()

2016-10-04 Thread Radim Krčmář
2016-10-03 13:03-0300, Eduardo Habkost: > On Fri, Sep 30, 2016 at 06:10:06PM +0200, Radim Krčmář wrote: >> Every configuration has only up to one APIC class and we'll be extending >> the class with a function that can be called without an instanced >> object, so a direct access to the class is conv

Re: [Qemu-devel] [PATCH v3 1/8] apic: add global apic_get_class()

2016-10-04 Thread Igor Mammedov
On Mon, 3 Oct 2016 13:03:33 -0300 Eduardo Habkost wrote: > On Fri, Sep 30, 2016 at 06:10:06PM +0200, Radim Krčmář wrote: > > Every configuration has only up to one APIC class and we'll be extending > > the class with a function that can be called without an instanced > > object, so a direct acces

Re: [Qemu-devel] [PATCH v3 1/8] apic: add global apic_get_class()

2016-10-03 Thread Eduardo Habkost
On Fri, Sep 30, 2016 at 06:10:06PM +0200, Radim Krčmář wrote: > Every configuration has only up to one APIC class and we'll be extending > the class with a function that can be called without an instanced > object, so a direct access to the class is convenient. > > This patch will break compilatio

[Qemu-devel] [PATCH v3 1/8] apic: add global apic_get_class()

2016-09-30 Thread Radim Krčmář
Every configuration has only up to one APIC class and we'll be extending the class with a function that can be called without an instanced object, so a direct access to the class is convenient. This patch will break compilation if some code uses apic_get_class() with CONFIG_USER_ONLY. Suggested-b