Re: [Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not using -seed

2019-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2019 at 12:23:18PM +0200, Philippe Mathieu-Daudé wrote: > On 4/13/19 8:44 AM, Richard Henderson wrote: > > On 4/10/19 11:49 PM, Philippe Mathieu-Daudé wrote: > >>> -if (seed_optarg != NULL) { > >>> -qemu_guest_random_seed_main(seed_optarg, _fatal); > >>> +{ > >>

Re: [Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not using -seed

2019-04-15 Thread Philippe Mathieu-Daudé
On 4/13/19 8:44 AM, Richard Henderson wrote: > On 4/10/19 11:49 PM, Philippe Mathieu-Daudé wrote: >>> -if (seed_optarg != NULL) { >>> -qemu_guest_random_seed_main(seed_optarg, _fatal); >>> +{ >> Since 7be41675f7c we use gnu99 C, so this extra block indentation can be >> removed. >>

Re: [Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not using -seed

2019-04-13 Thread Richard Henderson
On 4/10/19 11:49 PM, Philippe Mathieu-Daudé wrote: >> -if (seed_optarg != NULL) { >> -qemu_guest_random_seed_main(seed_optarg, _fatal); >> +{ > Since 7be41675f7c we use gnu99 C, so this extra block indentation can be > removed. > >> +Error *err = NULL; >> +if

Re: [Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not using -seed

2019-04-11 Thread Philippe Mathieu-Daudé
Hi Richard, On 3/15/19 4:26 AM, Richard Henderson wrote: > Cc: Laurent Vivier > Signed-off-by: Richard Henderson > --- > linux-user/main.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index

[Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not using -seed

2019-03-14 Thread Richard Henderson
Cc: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/main.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index cf7095bdaf..8478306eef 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -38,6 +38,7