Re: [Qemu-devel] [PATCH v3 14/19] nbd/client: Pull out oldstyle size determination

2019-01-16 Thread Eric Blake
On 1/15/19 9:35 AM, Vladimir Sementsov-Ogievskiy wrote: > 12.01.2019 20:58, Eric Blake wrote: >> Another refactoring creating nbd_negotiate_finish_oldstyle() >> for further reuse during 'qemu-nbd --list'. >> >> Signed-off-by: Eric Blake >> Message-Id: <20181215135324.152629-18-ebl...@redhat.com>

Re: [Qemu-devel] [PATCH v3 14/19] nbd/client: Pull out oldstyle size determination

2019-01-15 Thread Vladimir Sementsov-Ogievskiy
15.01.2019 18:35, Vladimir Sementsov-Ogievskiy wrote: > It must be set to true before calling, and nbd_start_negotiate may set it to > true. set it to false, I wanted to say -- Best regards, Vladimir

Re: [Qemu-devel] [PATCH v3 14/19] nbd/client: Pull out oldstyle size determination

2019-01-15 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:58, Eric Blake wrote: > Another refactoring creating nbd_negotiate_finish_oldstyle() > for further reuse during 'qemu-nbd --list'. > > Signed-off-by: Eric Blake > Message-Id: <20181215135324.152629-18-ebl...@redhat.com> > Reviewed-by: Richard W.M. Jones Reviewed-by: Vladimir

[Qemu-devel] [PATCH v3 14/19] nbd/client: Pull out oldstyle size determination

2019-01-12 Thread Eric Blake
Another refactoring creating nbd_negotiate_finish_oldstyle() for further reuse during 'qemu-nbd --list'. Signed-off-by: Eric Blake Message-Id: <20181215135324.152629-18-ebl...@redhat.com> Reviewed-by: Richard W.M. Jones --- nbd/client.c | 49 - 1