On Thu, Jan 24, 2019 at 09:12:58PM +0100, Zoltán Kővágó wrote:
> On 2019-01-24 12:19, Gerd Hoffmann wrote:
> > Hi,
> >
> >> So, I think with the first part the only open issue is whenever we go
> >> with the nested types (i.e. patch #1 as-is) or not. Given that the
> >> one-element-structs adde
On 2019-01-24 12:19, Gerd Hoffmann wrote:
> Hi,
>
>> So, I think with the first part the only open issue is whenever we go
>> with the nested types (i.e. patch #1 as-is) or not. Given that the
>> one-element-structs added in that patch will get additional fields I
>> think the nesting makes sen
Hi,
> So, I think with the first part the only open issue is whenever we go
> with the nested types (i.e. patch #1 as-is) or not. Given that the
> one-element-structs added in that patch will get additional fields I
> think the nesting makes sense.
Spoke too soon: scripts/checkpatch.pl flags a
On Wed, Jan 23, 2019 at 09:16:07PM +0100, Zoltán Kővágó wrote:
> On 2019-01-17 10:22, Gerd Hoffmann wrote:
> > On Thu, Jan 17, 2019 at 12:36:48AM +0100, Kővágó, Zoltán wrote:
> >> Remove glob_audio_state from functions, where possible without breaking
> >> the API. This means that most static func
On 2019-01-17 10:22, Gerd Hoffmann wrote:
> On Thu, Jan 17, 2019 at 12:36:48AM +0100, Kővágó, Zoltán wrote:
>> Remove glob_audio_state from functions, where possible without breaking
>> the API. This means that most static functions in audio.c now take an
>> AudioState pointer instead of implicitl
On Thu, Jan 17, 2019 at 12:36:48AM +0100, Kővágó, Zoltán wrote:
> Remove glob_audio_state from functions, where possible without breaking
> the API. This means that most static functions in audio.c now take an
> AudioState pointer instead of implicitly using glob_audio_state. Also
> included a po
Remove glob_audio_state from functions, where possible without breaking
the API. This means that most static functions in audio.c now take an
AudioState pointer instead of implicitly using glob_audio_state. Also
included a pointer in SWVoice*, HWVoice* structs, so that functions
dealing them can