Re: [Qemu-devel] [PATCH v3 18/18] qapi: Add parameter to visit_end_*

2016-05-03 Thread Eric Blake
On 05/03/2016 05:53 AM, Markus Armbruster wrote: > Okay, I'm confused. > > Consider BlockdevRef, defined as > > { 'alternate': 'BlockdevRef', > 'data': { 'definition': 'BlockdevOptions', > 'reference': 'str' } } > > where BlockdevOptions is a (flat) union. Let's clone

Re: [Qemu-devel] [PATCH v3 18/18] qapi: Add parameter to visit_end_*

2016-05-03 Thread Markus Armbruster
Eric Blake writes: > On 05/02/2016 12:20 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Rather than making the dealloc visitor track of stack of pointers >>> remembered during visit_start_* in order to free them during >>> visit_end_*, it's a lot easier to just make all callers pass

Re: [Qemu-devel] [PATCH v3 18/18] qapi: Add parameter to visit_end_*

2016-05-02 Thread Eric Blake
On 05/02/2016 12:20 PM, Markus Armbruster wrote: > Eric Blake writes: > >> Rather than making the dealloc visitor track of stack of pointers >> remembered during visit_start_* in order to free them during >> visit_end_*, it's a lot easier to just make all callers pass the >> same pointer to visit

Re: [Qemu-devel] [PATCH v3 18/18] qapi: Add parameter to visit_end_*

2016-05-02 Thread Markus Armbruster
Eric Blake writes: > Rather than making the dealloc visitor track of stack of pointers > remembered during visit_start_* in order to free them during > visit_end_*, it's a lot easier to just make all callers pass the > same pointer to visit_end_*. The generated code has access to the > same poin

[Qemu-devel] [PATCH v3 18/18] qapi: Add parameter to visit_end_*

2016-04-28 Thread Eric Blake
Rather than making the dealloc visitor track of stack of pointers remembered during visit_start_* in order to free them during visit_end_*, it's a lot easier to just make all callers pass the same pointer to visit_end_*. The generated code has access to the same pointer, while all other users are