Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-12 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Thu, Jul 04, 2013 at 08:28:59AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Tue, Jul 02, 2013 at 03:27:12PM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Tue, Jul 02, 2013 at 11:05:56AM +0200,

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-12 Thread Amos Kong
On Fri, Jul 12, 2013 at 08:32:29AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Thu, Jul 04, 2013 at 08:28:59AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Tue, Jul 02, 2013 at 03:27:12PM +0200, Markus Armbruster wrote: Amos Kong

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-11 Thread Amos Kong
On Thu, Jul 04, 2013 at 08:28:59AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Tue, Jul 02, 2013 at 03:27:12PM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Tue, Jul 02, 2013 at 11:05:56AM +0200, Markus Armbruster wrote: Amos Kong

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-04 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Tue, Jul 02, 2013 at 03:27:12PM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Tue, Jul 02, 2013 at 11:05:56AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: [...] This interface is abstract in the sense

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-03 Thread Amos Kong
On Tue, Jul 02, 2013 at 03:27:12PM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Tue, Jul 02, 2013 at 11:05:56AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: [...] This interface is abstract in the sense that it applies to all NICs. At

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-02 Thread Amos Kong
On Wed, Jun 26, 2013 at 11:54:20AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table. The previous patch adds QMP event

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-02 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Wed, Jun 26, 2013 at 11:54:20AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table.

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-02 Thread Amos Kong
On Tue, Jul 02, 2013 at 11:05:56AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: diff --git a/net/net.c b/net/net.c index 43a74e4..7b73a10 100644 --- a/net/net.c +++ b/net/net.c @@ -961,6 +961,53 @@ void print_net_client(Monitor *mon, NetClientState *nc)

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-02 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Tue, Jul 02, 2013 at 11:05:56AM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: [...] This interface is abstract in the sense that it applies to all NICs. At this time, it's implemented only virtio-net implements it. I'm

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-30 Thread Amos Kong
On Fri, Jun 28, 2013 at 07:27:21PM +0200, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: On 06/26/2013 08:15 AM, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 26 Jun 2013 14:00:30 +0200 Markus Armbruster arm...@redhat.com wrote:

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-28 Thread Eric Blake
On 06/26/2013 08:15 AM, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 26 Jun 2013 14:00:30 +0200 Markus Armbruster arm...@redhat.com wrote: Meh, I got confused and reviewed an out-of-date version. Hope it's not entirely noise. I don't think it is. But

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 06/26/2013 08:15 AM, Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 26 Jun 2013 14:00:30 +0200 Markus Armbruster arm...@redhat.com wrote: Meh, I got confused and reviewed an out-of-date version. Hope it's not

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 05/23/2013 03:08 AM, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table. The previous patch adds QMP event to notify management of

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 05/24/2013 07:08 AM, Luiz Capitulino wrote: This sounds like premature optimization to me, but I wonder if instead of cluttering commands with arguments to do the filtering we could add some standard way of doing this in the QAPI. Maybe we could make

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table. The previous patch adds QMP event to notify management of rx-filter change. This patch adds a monitor

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Markus Armbruster
Meh, I got confused and reviewed an out-of-date version. Hope it's not entirely noise.

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Luiz Capitulino
On Wed, 26 Jun 2013 14:00:30 +0200 Markus Armbruster arm...@redhat.com wrote: Meh, I got confused and reviewed an out-of-date version. Hope it's not entirely noise. I don't think it is. But this series got applied to Michael's tree, so if you want your comments addressed before applying to

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-06-26 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 26 Jun 2013 14:00:30 +0200 Markus Armbruster arm...@redhat.com wrote: Meh, I got confused and reviewed an out-of-date version. Hope it's not entirely noise. I don't think it is. But this series got applied to Michael's tree, so if

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-27 Thread Stefan Hajnoczi
On Sun, May 26, 2013 at 10:38:14AM +0300, Michael S. Tsirkin wrote: On Fri, May 24, 2013 at 04:00:42PM -0400, Luiz Capitulino wrote: On Fri, 24 May 2013 12:05:12 -0600 Eric Blake ebl...@redhat.com wrote: On 05/24/2013 10:12 AM, Michael S. Tsirkin wrote: Event message contains

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-26 Thread Michael S. Tsirkin
On Fri, May 24, 2013 at 04:00:42PM -0400, Luiz Capitulino wrote: On Fri, 24 May 2013 12:05:12 -0600 Eric Blake ebl...@redhat.com wrote: On 05/24/2013 10:12 AM, Michael S. Tsirkin wrote: Event message contains the net client name, management might only want to query the single net

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 11:08:13 +0800 Amos Kong ak...@redhat.com wrote: On Thu, May 23, 2013 at 12:03:25PM -0400, Luiz Capitulino wrote: On Thu, 23 May 2013 17:08:00 +0800 Amos Kong ak...@redhat.com wrote: A flag is used to avoid events flooding, if user don't query rx-filter after

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Eric Blake
On 05/24/2013 06:23 AM, Luiz Capitulino wrote: I don't think we need this argument. This command is quite simple in its response, let's do this filtering in HMP only. Event message contains the net client name, management might only want to query the single net client. The client can do

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 06:55:44 -0600 Eric Blake ebl...@redhat.com wrote: On 05/24/2013 06:23 AM, Luiz Capitulino wrote: I don't think we need this argument. This command is quite simple in its response, let's do this filtering in HMP only. Event message contains the net client name,

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Eric Blake
On 05/24/2013 07:08 AM, Luiz Capitulino wrote: This sounds like premature optimization to me, but I wonder if instead of cluttering commands with arguments to do the filtering we could add some standard way of doing this in the QAPI. Maybe we could make QAPI support generic filtering for all

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 05/24/2013 06:23 AM, Luiz Capitulino wrote: I don't think we need this argument. This command is quite simple in its response, let's do this filtering in HMP only. Event message contains the net client name, management might only want to query the

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Michael S. Tsirkin
On Fri, May 24, 2013 at 05:20:13PM +0200, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: On 05/24/2013 06:23 AM, Luiz Capitulino wrote: I don't think we need this argument. This command is quite simple in its response, let's do this filtering in HMP only. Event message

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Eric Blake
On 05/24/2013 10:12 AM, Michael S. Tsirkin wrote: Event message contains the net client name, management might only want to query the single net client. The client can do the filtering itself. I'm not sure I buy the responsiveness argument. Sure, the fastest I/O is no I/O, but whether

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-24 Thread Luiz Capitulino
On Fri, 24 May 2013 12:05:12 -0600 Eric Blake ebl...@redhat.com wrote: On 05/24/2013 10:12 AM, Michael S. Tsirkin wrote: Event message contains the net client name, management might only want to query the single net client. The client can do the filtering itself. I'm not sure I

[Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Amos Kong
We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table. The previous patch adds QMP event to notify management of rx-filter change. This patch adds a monitor command to query rx-filter information. A

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Michael S. Tsirkin
On Thu, May 23, 2013 at 05:08:00PM +0800, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table. The previous patch adds QMP event to notify management of rx-filter change. This

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Eric Blake
On 05/23/2013 03:08 AM, Amos Kong wrote: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table. The previous patch adds QMP event to notify management of rx-filter change. This patch adds a monitor

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Luiz Capitulino
On Thu, 23 May 2013 17:08:00 +0800 Amos Kong ak...@redhat.com wrote: We want to implement mac programming over macvtap through Libvirt, related rx-filter configuration contains main mac, some of rx-mode and mac-table. The previous patch adds QMP event to notify management of rx-filter

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Amos Kong
On Thu, May 23, 2013 at 06:14:19AM -0600, Eric Blake wrote: On 05/23/2013 03:08 AM, Amos Kong wrote: +RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name, + Error **errp) +{ +NetClientState *nc; +RxFilterInfoList

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Amos Kong
On Thu, May 23, 2013 at 12:03:25PM -0400, Luiz Capitulino wrote: On Thu, 23 May 2013 17:08:00 +0800 Amos Kong ak...@redhat.com wrote: A flag is used to avoid events flooding, if user don't query rx-filter after receives one event, new events won't be sent to qmp monitor.

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-05-23 Thread Amos Kong
On Thu, May 23, 2013 at 01:23:40PM +0300, Michael S. Tsirkin wrote: On Thu, May 23, 2013 at 05:08:00PM +0800, Amos Kong wrote: +info-broadcast_allowed = n-nobcast; +info-multicast_overflow = n-mac_table.multi_overflow; +info-unicast_overflow = n-mac_table.uni_overflow; +