Re: [Qemu-devel] [PATCH v3 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-12 Thread Stefan Hajnoczi
On Tue, Aug 12, 2014 at 10:04:11AM +0800, Fam Zheng wrote: On Mon, 08/11 15:32, Stefan Hajnoczi wrote: On Mon, Aug 11, 2014 at 04:45:18PM +0800, Fam Zheng wrote: diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out index d7b0f50..f6d9dc1 100644 ---

[Qemu-devel] [PATCH v3 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-11 Thread Fam Zheng
Replace init/destroy with realize/unrealize in SCSIDeviceClass, which has errp as a parameter. So all the implementations now use error_setg instead of error_report for reporting error. Also in lsi53c895a, report the error when initializing the if=scsi devices, before dropping it, because in the

Re: [Qemu-devel] [PATCH v3 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-11 Thread Stefan Hajnoczi
On Mon, Aug 11, 2014 at 04:45:18PM +0800, Fam Zheng wrote: diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out index d7b0f50..f6d9dc1 100644 --- a/tests/qemu-iotests/051.out +++ b/tests/qemu-iotests/051.out @@ -122,7 +122,7 @@ QEMU_PROG: -drive if=virtio: Device

Re: [Qemu-devel] [PATCH v3 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-11 Thread Fam Zheng
On Mon, 08/11 15:32, Stefan Hajnoczi wrote: On Mon, Aug 11, 2014 at 04:45:18PM +0800, Fam Zheng wrote: diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out index d7b0f50..f6d9dc1 100644 --- a/tests/qemu-iotests/051.out +++ b/tests/qemu-iotests/051.out @@ -122,7 +122,7 @@