Re: [Qemu-devel] [PATCH v3 2/2] vmdk: Implment bdrv_get_specific_info

2013-10-17 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 08:08:35PM +0800, Fam Zheng wrote: > @@ -814,6 +821,7 @@ static int vmdk_open_desc_file(BlockDriverState *bs, int > flags, > ret = -ENOTSUP; > goto exit; > } > +s->create_type = g_strdup(ct); Where is this freed if opening the file fails?

[Qemu-devel] [PATCH v3 2/2] vmdk: Implment bdrv_get_specific_info

2013-10-11 Thread Fam Zheng
Implement .bdrv_get_specific_info to return the extent information. Signed-off-by: Fam Zheng --- block/vmdk.c | 57 +- qapi-schema.json | 24 ++- tests/qemu-iotests/059 | 2 +- tests/qemu-iotests/059.out |