Re: [Qemu-devel] [PATCH v3 2/4] hw/char: QOM'ify etraxfs_ser.c

2016-05-18 Thread xiaoqiang zhao
在 2016年05月17日 20:51, Paolo Bonzini 写道: I'm sorry, this is not enough. You need to learn how to test this device. CRIS images are available athttp://wiki.qemu.org/Testing. You have not added a replacement for the call to qemu_char_get_next_serial(). The board code in hw/cris/axis_dev88.c

Re: [Qemu-devel] [PATCH v3 2/4] hw/char: QOM'ify etraxfs_ser.c

2016-05-17 Thread Paolo Bonzini
On 13/05/2016 05:07, xiaoqiang zhao wrote: > * Drop the old SysBus init function and use instance_init > * Call qemu_chr_add_handlers in the realize callback > * Use qdev chardev prop instead of qemu_char_get_next_serial > > Signed-off-by: xiaoqiang zhao > --- >

[Qemu-devel] [PATCH v3 2/4] hw/char: QOM'ify etraxfs_ser.c

2016-05-12 Thread xiaoqiang zhao
* Drop the old SysBus init function and use instance_init * Call qemu_chr_add_handlers in the realize callback * Use qdev chardev prop instead of qemu_char_get_next_serial Signed-off-by: xiaoqiang zhao --- hw/char/etraxfs_ser.c | 27 +-- 1 file