Re: [Qemu-devel] [PATCH v3 2/8] iotests: Prefer null-co over null-aio

2019-08-20 Thread John Snow
On 8/19/19 4:22 PM, Max Reitz wrote: > On 19.08.19 22:18, Max Reitz wrote: >> We use null-co basically everywhere in the iotests. Unless we want to >> test null-aio specifically, we should use it instead (for consistency). >> >> Signed-off-by: Max Reitz >> Reviewed-by: John Snow > > Hm,

Re: [Qemu-devel] [PATCH v3 2/8] iotests: Prefer null-co over null-aio

2019-08-20 Thread Thomas Huth
On 8/19/19 10:18 PM, Max Reitz wrote: > We use null-co basically everywhere in the iotests. Unless we want to > test null-aio specifically, we should use it instead (for consistency). > > Signed-off-by: Max Reitz > Reviewed-by: John Snow > --- > tests/qemu-iotests/093 | 7 +++ >

Re: [Qemu-devel] [PATCH v3 2/8] iotests: Prefer null-co over null-aio

2019-08-19 Thread Max Reitz
On 19.08.19 22:18, Max Reitz wrote: > We use null-co basically everywhere in the iotests. Unless we want to > test null-aio specifically, we should use it instead (for consistency). > > Signed-off-by: Max Reitz > Reviewed-by: John Snow Hm, sorry, I just noticed that I probably should have

[Qemu-devel] [PATCH v3 2/8] iotests: Prefer null-co over null-aio

2019-08-19 Thread Max Reitz
We use null-co basically everywhere in the iotests. Unless we want to test null-aio specifically, we should use it instead (for consistency). Signed-off-by: Max Reitz Reviewed-by: John Snow --- tests/qemu-iotests/093 | 7 +++ tests/qemu-iotests/245 | 2 +- 2 files changed, 4